From 594cb3035615b3a6cf3dc09ccee30554b56eb2f3 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Wed, 29 Jan 2020 07:50:16 -0800 Subject: [PATCH] loader: Fix leak of kernel driver name This is strdup'd, it needs to be freed. CID: 1458032 Fixes: f93bb2fb102 ("loader: Check if the kernel driver is i915 before loading iris") Reviewed-by: Eric Engestrom Reviewed-by: Sagar Ghuge Tested-by: Marge Bot Part-of: --- src/loader/loader.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/loader/loader.c b/src/loader/loader.c index a2fe0a241a2..c896fdc3360 100644 --- a/src/loader/loader.c +++ b/src/loader/loader.c @@ -118,7 +118,10 @@ bool is_kernel_i915(int fd) { char *kernel_driver = loader_get_kernel_driver_name(fd); - return kernel_driver && strcmp(kernel_driver, "i915") == 0; + bool is_i915 = kernel_driver && strcmp(kernel_driver, "i915") == 0; + + free(kernel_driver); + return is_i915; } #if defined(HAVE_LIBDRM) -- 2.30.2