From 59a561480d547d041127630b1ba17a284eef8225 Mon Sep 17 00:00:00 2001 From: Andreas Arnez Date: Mon, 20 Mar 2017 18:55:39 +0100 Subject: [PATCH] Fix spurious FAILs with examine-backward.exp The test case examine-backward.exp issues the command "x/-s" after the end of the first string in TestStrings, but without making sure that this string is preceded by a string terminator. Thus GDB may spuriously print some random characters from before that string, and then the test fails. This patch assures that TestStrings is preceded by a string terminator. gdb/testsuite/ChangeLog: * gdb.base/examine-backward.c (Barrier): New character array constant, to ensure that TestStrings is preceded by a string terminator. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.base/examine-backward.c | 8 ++++++++ 2 files changed, 14 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 018104c2199..2386c0a1810 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2017-03-20 Andreas Arnez + + * gdb.base/examine-backward.c (Barrier): New character array + constant, to ensure that TestStrings is preceded by a string + terminator. + 2017-03-16 Andreas Arnez * lib/dwarf.exp: Add support for DW_OP_implicit_pointer. diff --git a/gdb/testsuite/gdb.base/examine-backward.c b/gdb/testsuite/gdb.base/examine-backward.c index 5e9162a293a..462089d14e1 100644 --- a/gdb/testsuite/gdb.base/examine-backward.c +++ b/gdb/testsuite/gdb.base/examine-backward.c @@ -32,6 +32,14 @@ literals. The content of each array is the same as followings: }; */ +/* This is here just to ensure we have a null character before + TestStrings, to avoid showing garbage when we look for strings + backwards from TestStrings. */ + +const char Barrier[] = { + 0x00, +}; + const char TestStrings[] = { 0x41, 0x42, 0x43, 0x44, 0x45, 0x46, 0x47, 0x48, 0x49, 0x4a, 0x4b, 0x4c, 0x4d, 0x4e, 0x4f, 0x50, -- 2.30.2