From 5a79e0a8e37ea10cfa6fc39f4fbe315f9620fe52 Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Thu, 19 Nov 2015 15:31:06 +0000 Subject: [PATCH] automake: loader: rework the CPPFLAGS MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Rather than duplicating things, just use the generic AM_CPPFLAGS. This has the fortunate side-effect of adding VISIBILITY_CFLAGS for the dri3 helper. The latter of which was erroneously exposing some internal symbols. Signed-off-by: Emil Velikov Reported-by: Kai Wasserbäch Tested-by: Kai Wasserbäch Reviewed-by: Kristian Høgsberg Reviewed-by: Matt Turner --- src/loader/Makefile.am | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/loader/Makefile.am b/src/loader/Makefile.am index c0f79475361..67ed776b0c3 100644 --- a/src/loader/Makefile.am +++ b/src/loader/Makefile.am @@ -25,18 +25,20 @@ EXTRA_DIST = SConscript noinst_LTLIBRARIES = libloader.la libloader_dri3_helper.la -libloader_la_CPPFLAGS = \ +AM_CPPFLAGS = \ $(DEFINES) \ -I$(top_srcdir)/include \ -I$(top_srcdir)/src \ $(VISIBILITY_CFLAGS) \ + $(LIBDRM_CFLAGS) \ $(LIBUDEV_CFLAGS) libloader_la_SOURCES = $(LOADER_C_FILES) libloader_la_LIBADD = if HAVE_DRICOMMON -libloader_la_CPPFLAGS += \ +libloader_la_CPPFLAGS = \ + $(AM_CPPFLAGS) \ -I$(top_srcdir)/src/mesa/drivers/dri/common/ \ -I$(top_builddir)/src/mesa/drivers/dri/common/ \ -I$(top_srcdir)/src/mesa/ \ @@ -49,20 +51,11 @@ libloader_la_CPPFLAGS += \ endif if HAVE_LIBDRM -libloader_la_CPPFLAGS += \ - $(LIBDRM_CFLAGS) - libloader_la_LIBADD += \ $(LIBDRM_LIBS) endif if HAVE_DRI3 -libloader_dri3_helper_la_CPPFLAGS = \ - $(DEFINES) \ - -I$(top_srcdir)/include \ - -I$(top_srcdir)/src \ - $(LIBDRM_CFLAGS) - libloader_dri3_helper_la_SOURCES = \ loader_dri3_helper.c \ loader_dri3_helper.h -- 2.30.2