From 5c33112fa5a08f0fc94579f4cb4ae87210fa001a Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Sun, 30 Aug 2020 01:46:31 -0700 Subject: [PATCH] mips,cpu: Get rid of the IsDpsOp StaticInst flag. This flag was set by MIPS for a few instructions, but didn't have an accessor in StaticInst and was never used for anything. Change-Id: I153cedde0d16cb1d78b2705bd7340ebfd10e4fb6 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33740 Reviewed-by: Gabe Black Maintainer: Gabe Black Tested-by: kokoro --- src/arch/mips/isa/formats/dsp.isa | 4 ---- src/cpu/StaticInstFlags.py | 3 ++- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/arch/mips/isa/formats/dsp.isa b/src/arch/mips/isa/formats/dsp.isa index 9a6d6147e..12af2d61f 100644 --- a/src/arch/mips/isa/formats/dsp.isa +++ b/src/arch/mips/isa/formats/dsp.isa @@ -173,8 +173,6 @@ def format DspIntOp(code, *opt_flags) {{ code = decl_code + code + write_code - opt_flags += ('IsDspOp',) - iop = InstObjParams(name, Name, 'DspIntOp', code, opt_flags) header_output = BasicDeclare.subst(iop) decoder_output = BasicConstructor.subst(iop) @@ -204,8 +202,6 @@ def format DspHiLoOp(code, *opt_flags) {{ code = decl_code + fetch_code + code + write_code - opt_flags += ('IsDspOp',) - iop = InstObjParams(name, Name, 'DspHiLoOp', code, opt_flags) header_output = BasicDeclare.subst(iop) decoder_output = BasicConstructor.subst(iop) diff --git a/src/cpu/StaticInstFlags.py b/src/cpu/StaticInstFlags.py index 151074edc..27ba013ed 100644 --- a/src/cpu/StaticInstFlags.py +++ b/src/cpu/StaticInstFlags.py @@ -103,8 +103,9 @@ class StaticInstFlags(Enum): # This flag doesn't do anything yet 'IsMicroBranch', # This microop branches within the microcode for # a macroop - 'IsDspOp', + 'IsSquashAfter', # Squash all uncommitted state after executed + # hardware transactional memory 'IsHtmStart', # Starts a HTM transaction 'IsHtmStop', # Stops (commits) a HTM transaction -- 2.30.2