From 5c9e54f2ff2eb651b5bf594ac95d39ba5747c500 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Thu, 15 Jul 2010 00:20:41 -0700 Subject: [PATCH] glx: Move dereference and initialization to after NULL check. --- src/glx/glx_pbuffer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c index c081836376d..f6f931df7d2 100644 --- a/src/glx/glx_pbuffer.c +++ b/src/glx/glx_pbuffer.c @@ -86,7 +86,7 @@ ChangeDrawableAttribute(Display * dpy, GLXDrawable drawable, const CARD32 * attribs, size_t num_attribs) { __GLXdisplayPrivate *priv = __glXInitialize(dpy); - __GLXDRIdrawable *pdraw = GetGLXDRIDrawable(dpy, drawable, NULL); + __GLXDRIdrawable *pdraw; CARD32 *output; CARD8 opcode; int i; @@ -95,6 +95,8 @@ ChangeDrawableAttribute(Display * dpy, GLXDrawable drawable, return; } + pdraw = GetGLXDRIDrawable(dpy, drawable, NULL); + opcode = __glXSetupForCommand(dpy); if (!opcode) return; -- 2.30.2