From 5cbe12ad1b8934c932f19070044563b9f3b9ab21 Mon Sep 17 00:00:00 2001 From: Bas Nieuwenhuizen Date: Mon, 6 May 2019 01:42:21 +0200 Subject: [PATCH] radv: Disable subsampled formats. Broken on Polaris and since I discovered NV12 is not subsampled, but a 2-plane format I decided I don't really care. Work to do to re-enable: 1) Figure out which devices support it natively. 2) Write some software emulation for the others. Fixes: 52c1adda21b "radv: Add ycbcr format features." Reviewed-by: Samuel Pitoiset --- src/amd/vulkan/radv_formats.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c index 5af172c8e7f..f6e50442009 100644 --- a/src/amd/vulkan/radv_formats.c +++ b/src/amd/vulkan/radv_formats.c @@ -635,7 +635,8 @@ radv_physical_device_get_format_properties(struct radv_physical_device *physical const struct vk_format_description *desc = vk_format_description(format); bool blendable; bool scaled = false; - if (!desc) { + /* TODO: implement some software emulation of SUBSAMPLED formats. */ + if (!desc || desc->layout == VK_FORMAT_LAYOUT_SUBSAMPLED) { out_properties->linearTilingFeatures = linear; out_properties->optimalTilingFeatures = tiled; out_properties->bufferFeatures = buffer; -- 2.30.2