From 5ced83ee1561553d9eba831fa356bf63cc214447 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Thu, 28 Aug 2014 15:33:56 -0700 Subject: [PATCH] glsl: Initialize source_chan in opt_copy_propagation_elements. Previously, if chans < 4, we passed uninitialized stack garbage to the ir_swizzle constructor for the excess components. Thankfully, it ignores that data, as it's unnecessary, so no harm actually comes of it. However, it's obviously better to initialize it. Signed-off-by: Kenneth Graunke Reviewed-by: Matt Turner --- src/glsl/opt_copy_propagation_elements.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/opt_copy_propagation_elements.cpp b/src/glsl/opt_copy_propagation_elements.cpp index f5f59b7d34a..f131894608d 100644 --- a/src/glsl/opt_copy_propagation_elements.cpp +++ b/src/glsl/opt_copy_propagation_elements.cpp @@ -207,7 +207,7 @@ ir_copy_propagation_elements_visitor::handle_rvalue(ir_rvalue **ir) int swizzle_chan[4]; ir_dereference_variable *deref_var; ir_variable *source[4] = {NULL, NULL, NULL, NULL}; - int source_chan[4]; + int source_chan[4] = {0, 0, 0, 0}; int chans; if (!*ir) -- 2.30.2