From 5d26e0baf223b361c9919db213915a82d2dff5c4 Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Mon, 21 Aug 2017 14:10:21 +1000 Subject: [PATCH] radv: don't degrade tiling mode for small compressed or depth texture. This is what radeonsi does, so we should do the same, also vega doesn't support linear depth textures anyways. Reviewed-by: Bas Nieuwenhuizen Cc: "17.2" Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index 78f52a8f729..684e804cc99 100644 --- a/src/amd/vulkan/radv_image.c +++ b/src/amd/vulkan/radv_image.c @@ -44,12 +44,16 @@ radv_choose_tiling(struct radv_device *Device, return RADEON_SURF_MODE_LINEAR_ALIGNED; } - /* Textures with a very small height are recommended to be linear. */ - if (pCreateInfo->imageType == VK_IMAGE_TYPE_1D || - /* Only very thin and long 2D textures should benefit from - * linear_aligned. */ - (pCreateInfo->extent.width > 8 && pCreateInfo->extent.height <= 2)) - return RADEON_SURF_MODE_LINEAR_ALIGNED; + if (!vk_format_is_compressed(pCreateInfo->format) && + !vk_format_is_depth_or_stencil(pCreateInfo->format)) { + /* Textures with a very small height are recommended to be linear. */ + if (pCreateInfo->imageType == VK_IMAGE_TYPE_1D || + /* Only very thin and long 2D textures should benefit from + * linear_aligned. */ + (pCreateInfo->extent.width > 8 && pCreateInfo->extent.height <= 2)) + return RADEON_SURF_MODE_LINEAR_ALIGNED; + + } /* MSAA resources must be 2D tiled. */ if (pCreateInfo->samples > 1) -- 2.30.2