From 5f1ca24acd8fd4e21c4f6f3ed2bbc4e2365215fe Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Fri, 24 Nov 2017 17:10:25 -0500 Subject: [PATCH] Fix issues with gdb-memory-map.dtd While writing a unit test for parse_memory_map, I tried to validate my test input against gdb-memory-map.dtd, and found a few problems with it. This doesn't influence how gdb parses it (AFAIK it doesn't use the linked dtd), but if you edit the xml file in an editor that supports dtds, you'll get plenty of errors. - The element accepts exactly one OR as a child. This is a problem because you can't have multiple elements and you shouldn't be able to have elements as direct children of . - The element wants exactly one child. This is wrong, since you could have zero or more (even though we only support one kind of property currently). - I have no idea wht the device attribute of is, GDB doesn't read that. I searched back in time a bit but couldn't find a trace of it. I took the opportunity to tighten what is accepted as a value of the memory type and property name attributes. We currently accept any string, but we can restrict them to the values GDB really accepts (and which are documented). AFAIK, this "file" only exists in the documentation, in gdb.texinfo, so this is what I modified. However, it's also available at http://sourceware.org/gdb/gdb-memory-map.dtd. This one should be updated too, but I don't know how that should be done. gdb/doc/ChangeLog: * gdb.texinfo (Memory Map Format): Update gdb-memory-map.dtd. --- gdb/doc/ChangeLog | 4 ++++ gdb/doc/gdb.texinfo | 11 +++++------ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 62c63f1785e..79a4025ba34 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,7 @@ +2017-11-24 Simon Marchi + + * gdb.texinfo (Memory Map Format): Update gdb-memory-map.dtd. + 2017-11-24 Pedro Alves * gdb.texinfo (Completion): Update need-quoting examples. Remove diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index afaafc0c49f..f7067464a8b 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -40840,18 +40840,17 @@ The formal DTD for memory map format is given below: - + - + - + length CDATA #REQUIRED> - + @end smallexample @node Thread List Format -- 2.30.2