From 5f7282e2cb8e65e77e97001b02a13a658cec7805 Mon Sep 17 00:00:00 2001 From: Jason Merrill Date: Mon, 17 Nov 2014 17:09:27 -0500 Subject: [PATCH] re PR c++/33911 (attribute deprecated vs. templates) PR c++/33911 gcc/cp/ * call.c (build_call_a): Don't warn_deprecated_use here. (build_over_call): Or here. * decl2.c (mark_used): Do it here. (is_late_template_attribute): Attribute deprecated is not deferred. (cplus_decl_attributes): Propagate TREE_DEPRECATED out to the template. * parser.c (cp_parser_template_name): Warn about deprecated template. (cp_parser_template_argument): Likewise. libstdc++-v3/ * include/backward/binders.h: Suppress -Wdeprecated-declarations. * include/ext/array_allocator.h: Likewise. From-SVN: r217677 --- gcc/cp/ChangeLog | 9 +++++++++ gcc/cp/call.c | 7 ------- gcc/cp/decl2.c | 19 +++++++++++++++++-- gcc/cp/parser.c | 12 ++++++++++-- gcc/testsuite/g++.dg/ext/attr-deprecated-1.C | 15 +++++++++++++++ libstdc++-v3/ChangeLog | 5 +++++ libstdc++-v3/include/backward/binders.h | 6 ++++++ libstdc++-v3/include/ext/array_allocator.h | 6 ++++++ 8 files changed, 68 insertions(+), 11 deletions(-) create mode 100644 gcc/testsuite/g++.dg/ext/attr-deprecated-1.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 05ca4931910..6e7f657c6ee 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,5 +1,14 @@ 2014-11-17 Jason Merrill + PR c++/33911 + * call.c (build_call_a): Don't warn_deprecated_use here. + (build_over_call): Or here. + * decl2.c (mark_used): Do it here. + (is_late_template_attribute): Attribute deprecated is not deferred. + (cplus_decl_attributes): Propagate TREE_DEPRECATED out to the template. + * parser.c (cp_parser_template_name): Warn about deprecated template. + (cp_parser_template_argument): Likewise. + PR c++/50473 * decl.c (cp_finish_decl): Don't try to process a non-dependent constant initializer for a reference. diff --git a/gcc/cp/call.c b/gcc/cp/call.c index 06162aa6286..c180890b965 100644 --- a/gcc/cp/call.c +++ b/gcc/cp/call.c @@ -387,8 +387,6 @@ build_call_a (tree function, int n, tree *argarray) mark_used (decl); } - if (decl && TREE_DEPRECATED (decl)) - warn_deprecated_use (decl, NULL_TREE); require_complete_eh_spec_types (fntype, decl); TREE_HAS_CONSTRUCTOR (function) = (decl && DECL_CONSTRUCTOR_P (decl)); @@ -7447,11 +7445,6 @@ build_over_call (struct z_candidate *cand, int flags, tsubst_flags_t complain) ba_any, NULL, complain); gcc_assert (binfo && binfo != error_mark_node); - /* Warn about deprecated virtual functions now, since we're about - to throw away the decl. */ - if (TREE_DEPRECATED (fn)) - warn_deprecated_use (fn, NULL_TREE); - argarray[0] = build_base_path (PLUS_EXPR, argarray[0], binfo, 1, complain); if (TREE_SIDE_EFFECTS (argarray[0])) diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c index fb8d0c82e40..f3b94a93dc5 100644 --- a/gcc/cp/decl2.c +++ b/gcc/cp/decl2.c @@ -1204,9 +1204,9 @@ is_late_template_attribute (tree attr, tree decl) /* Also defer most attributes on dependent types. This is not necessary in all cases, but is the better default. */ else if (dependent_type_p (type) - /* But attributes abi_tag and visibility specifically apply - to templates. */ + /* But some attributes specifically apply to templates. */ && !is_attribute_p ("abi_tag", name) + && !is_attribute_p ("deprecated", name) && !is_attribute_p ("visibility", name)) return true; else @@ -1482,6 +1482,17 @@ cplus_decl_attributes (tree *decl, tree attributes, int flags) if (TREE_CODE (*decl) == TYPE_DECL) SET_IDENTIFIER_TYPE_VALUE (DECL_NAME (*decl), TREE_TYPE (*decl)); + + /* Propagate deprecation out to the template. */ + if (TREE_DEPRECATED (*decl)) + if (tree ti = get_template_info (*decl)) + { + tree tmpl = TI_TEMPLATE (ti); + tree pattern = (TYPE_P (*decl) ? TREE_TYPE (tmpl) + : DECL_TEMPLATE_RESULT (tmpl)); + if (*decl == pattern) + TREE_DEPRECATED (tmpl) = true; + } } /* Walks through the namespace- or function-scope anonymous union @@ -4891,6 +4902,10 @@ mark_used (tree decl, tsubst_flags_t complain) return false; } + if (TREE_DEPRECATED (decl) && (complain & tf_warning) + && deprecated_state != DEPRECATED_SUPPRESS) + warn_deprecated_use (decl, NULL_TREE); + /* We can only check DECL_ODR_USED on variables or functions with DECL_LANG_SPECIFIC set, and these are also the only decls that we might need special handling for. */ diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c index 3eff5fad862..b106f3b03cd 100644 --- a/gcc/cp/parser.c +++ b/gcc/cp/parser.c @@ -13959,7 +13959,11 @@ cp_parser_template_name (cp_parser* parser, /* If DECL is a template, then the name was a template-name. */ if (TREE_CODE (decl) == TEMPLATE_DECL) - ; + { + if (TREE_DEPRECATED (decl) + && deprecated_state != DEPRECATED_SUPPRESS) + warn_deprecated_use (decl, NULL_TREE); + } else { tree fn = NULL_TREE; @@ -14193,7 +14197,11 @@ cp_parser_template_argument (cp_parser* parser) cp_parser_error (parser, "expected template-name"); } if (cp_parser_parse_definitely (parser)) - return argument; + { + if (TREE_DEPRECATED (argument)) + warn_deprecated_use (argument, NULL_TREE); + return argument; + } /* It must be a non-type argument. There permitted cases are given in [temp.arg.nontype]: diff --git a/gcc/testsuite/g++.dg/ext/attr-deprecated-1.C b/gcc/testsuite/g++.dg/ext/attr-deprecated-1.C new file mode 100644 index 00000000000..31a76903cb5 --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/attr-deprecated-1.C @@ -0,0 +1,15 @@ +// PR c++/33911 + +template struct __attribute__ ((deprecated)) S {}; +S s; // { dg-warning "deprecated" } + +template