From 608c3d2083be9de1eadac6dad67cd571888ca5d7 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Fri, 27 Jan 2012 16:09:48 -0800 Subject: [PATCH] mesa: Restore depth texture state on glPopAttrib(GL_TEXTURE_BIT). According to Table 6.17 in the GL 2.1 specification, DEPTH_TEXTURE_MODE, TEXTURE_COMPARE_MODE, and TEXTURE_COMPARE_FUNC need to be restored on glPopAttrib(GL_TEXTURE_BIT). Makes a number of oglconform tests happier. v2: Make restoration conditional on the ARB_shadow and ARB_depth_texture extensions, as suggested by Brian. I'm not sure that any implementations still remain that don't support those, but why not? NOTE: This is a candidate for stable release branches. Signed-off-by: Kenneth Graunke Reviewed-by: Brian Paul Reviewed-by: Eric Anholt --- src/mesa/main/attrib.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index b114ec9414d..318d576e850 100644 --- a/src/mesa/main/attrib.c +++ b/src/mesa/main/attrib.c @@ -799,6 +799,14 @@ pop_texture_group(struct gl_context *ctx, struct texture_state *texstate) _mesa_TexParameterf(target, GL_TEXTURE_COMPARE_FAIL_VALUE_ARB, samp->CompareFailValue); } + if (ctx->Extensions.ARB_shadow) { + _mesa_TexParameteri(target, GL_TEXTURE_COMPARE_MODE, + samp->CompareMode); + _mesa_TexParameteri(target, GL_TEXTURE_COMPARE_FUNC, + samp->CompareFunc); + } + if (ctx->Extensions.ARB_depth_texture) + _mesa_TexParameteri(target, GL_DEPTH_TEXTURE_MODE, samp->DepthMode); } /* remove saved references to the texture objects */ -- 2.30.2