From 60be64b396c29a06a00bfef56758cee3a141bf22 Mon Sep 17 00:00:00 2001 From: Bernd Edlinger Date: Wed, 2 Jun 2021 19:18:04 +0200 Subject: [PATCH] Fix temp-dir leakage in per-bfd-sharing.exp Whan using clang as compiler this compile step fails due to the unknown option "-Wl,--build-id". This leaks the already created temp-dir. Fixed by compiling first, and creating the temp-dir only when the compile succeeded. 2021-06-02 Bernd Edlinger * gdb.dwarf2/per-bfd-sharing.exp: Fix temp-dir leakage. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp | 10 +++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index a0469c8623b..7959f58c3c4 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2021-06-02 Bernd Edlinger + + * gdb.dwarf2/per-bfd-sharing.exp: Fix temp-dir leakage. + 2021-06-02 Carl Love * gdb.threads/threadapply.c: Add global mybarrier. diff --git a/gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp b/gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp index 081088a9839..48a30fa741c 100644 --- a/gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp +++ b/gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp @@ -18,6 +18,11 @@ standard_testfile +if { [build_executable "failed to prepare" $testfile $srcfile \ + {debug additional_flags=-Wl,--build-id}] == -1 } { + return +} + lassign [remote_exec host mktemp -d] ret cache_dir # The output of mktemp contains an end of line, remove it. @@ -30,11 +35,6 @@ if { $ret != 0 } { verbose -log "Index cache dir: $cache_dir" -if { [build_executable "failed to prepare" $testfile $srcfile \ - {debug additional_flags=-Wl,--build-id}] == -1 } { - return -} - # Populate the index-cache. with_test_prefix "populate index cache" { clean_restart -- 2.30.2