From 6109320673fe30163b5d00d9e3a7f4e77befb22a Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Wed, 10 May 2023 23:05:00 +0930 Subject: [PATCH] Re: stack overflow in debug_write_type Apparently u.kindirect->slot can point at a NULL. * debug.c (debug_write_type): Don't segfault on NULL indirect. --- binutils/debug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/binutils/debug.c b/binutils/debug.c index 5cc77f74906..bb26d9143d0 100644 --- a/binutils/debug.c +++ b/binutils/debug.c @@ -2490,7 +2490,8 @@ debug_write_type (struct debug_handle *info, return false; case DEBUG_KIND_INDIRECT: /* Prevent infinite recursion. */ - if ((*type->u.kindirect->slot)->mark == info->mark) + if (*type->u.kindirect->slot != DEBUG_TYPE_NULL + && (*type->u.kindirect->slot)->mark == info->mark) return (*fns->empty_type) (fhandle); return debug_write_type (info, fns, fhandle, *type->u.kindirect->slot, name); -- 2.30.2