From 614b09cefb3bafa840fe5ed06c58024b0ff9c1cb Mon Sep 17 00:00:00 2001 From: Jiong Wang Date: Tue, 26 Aug 2014 15:48:47 +0100 Subject: [PATCH] [AArch64] Improve copy relocation support on four absolute relocation types 2014-08-26 Jiong Wang bfd/ * elfnn-aarch64.c (elfNN_aarch64_check_relocs): Initialize non_got_ref properly for MOVW_G0/1/2_NC and MOVW_G3. Reject them when linking shared library. (elfNN_aarch64_gc_sweep_hook): Add check on these relocs. ld/testsuite/ * ld-aarch64/copy-relocs-so.s: New test file. * ld-aarch64/copy-relocs-exe.s: Likewise. * ld-aarch64/copy-relocs.d: New expectation file. * ld-aarch64/emit-relocs-264-bad.d: New test file. * ld-aarch64/emit-relocs-266-bad.d: Likewise. * ld-aarch64/emit-relocs-268-bad.d: Likewise. * ld-aarch64/emit-relocs-269-bad.d: Likewise. * ld-aarch64/aarch64-elf.exp: Run new added test. --- bfd/ChangeLog | 7 ++++ bfd/elfnn-aarch64.c | 33 +++++++++++++------ ld/testsuite/ChangeLog | 11 +++++++ ld/testsuite/ld-aarch64/aarch64-elf.exp | 13 ++++++++ ld/testsuite/ld-aarch64/copy-reloc-exe.s | 7 ++++ ld/testsuite/ld-aarch64/copy-reloc-so.s | 6 ++++ ld/testsuite/ld-aarch64/copy-reloc.d | 4 +++ ld/testsuite/ld-aarch64/emit-relocs-264-bad.d | 3 ++ ld/testsuite/ld-aarch64/emit-relocs-266-bad.d | 3 ++ ld/testsuite/ld-aarch64/emit-relocs-268-bad.d | 3 ++ ld/testsuite/ld-aarch64/emit-relocs-269-bad.d | 3 ++ 11 files changed, 83 insertions(+), 10 deletions(-) create mode 100644 ld/testsuite/ld-aarch64/copy-reloc-exe.s create mode 100644 ld/testsuite/ld-aarch64/copy-reloc-so.s create mode 100644 ld/testsuite/ld-aarch64/copy-reloc.d create mode 100644 ld/testsuite/ld-aarch64/emit-relocs-264-bad.d create mode 100644 ld/testsuite/ld-aarch64/emit-relocs-266-bad.d create mode 100644 ld/testsuite/ld-aarch64/emit-relocs-268-bad.d create mode 100644 ld/testsuite/ld-aarch64/emit-relocs-269-bad.d diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 9e5b6d96ca2..d94f590327b 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2014-08-26 Jiong Wang + + * elfnn-aarch64.c (elfNN_aarch64_check_relocs): Initialize non_got_ref + properly for MOVW_G0/1/2_NC and MOVW_G3. Reject them when linking + shared library. + (elfNN_aarch64_gc_sweep_hook): Add check on these relocs. + 2014-08-26 Nick Clifton * config.bfd: Fix typo in or1knd selection. diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c index 4dfb6043ae6..d7b30374370 100644 --- a/bfd/elfnn-aarch64.c +++ b/bfd/elfnn-aarch64.c @@ -4766,16 +4766,6 @@ elfNN_aarch64_gc_sweep_hook (bfd *abfd, } break; - case BFD_RELOC_AARCH64_ADR_HI21_NC_PCREL: - case BFD_RELOC_AARCH64_ADR_HI21_PCREL: - case BFD_RELOC_AARCH64_ADR_LO21_PCREL: - if (h != NULL && info->executable) - { - if (h->plt.refcount > 0) - h->plt.refcount -= 1; - } - break; - case BFD_RELOC_AARCH64_CALL26: case BFD_RELOC_AARCH64_JUMP26: /* If this is a local symbol then we resolve it @@ -4787,6 +4777,13 @@ elfNN_aarch64_gc_sweep_hook (bfd *abfd, h->plt.refcount -= 1; break; + case BFD_RELOC_AARCH64_MOVW_G0_NC: + case BFD_RELOC_AARCH64_MOVW_G1_NC: + case BFD_RELOC_AARCH64_MOVW_G2_NC: + case BFD_RELOC_AARCH64_MOVW_G3: + case BFD_RELOC_AARCH64_ADR_HI21_NC_PCREL: + case BFD_RELOC_AARCH64_ADR_HI21_PCREL: + case BFD_RELOC_AARCH64_ADR_LO21_PCREL: case BFD_RELOC_AARCH64_NN: if (h != NULL && info->executable) { @@ -5283,6 +5280,22 @@ elfNN_aarch64_check_relocs (bfd *abfd, struct bfd_link_info *info, break; } + case BFD_RELOC_AARCH64_MOVW_G0_NC: + case BFD_RELOC_AARCH64_MOVW_G1_NC: + case BFD_RELOC_AARCH64_MOVW_G2_NC: + case BFD_RELOC_AARCH64_MOVW_G3: + if (info->shared) + { + int howto_index = bfd_r_type - BFD_RELOC_AARCH64_RELOC_START; + (*_bfd_error_handler) + (_("%B: relocation %s against `%s' can not be used when making " + "a shared object; recompile with -fPIC"), + abfd, elfNN_aarch64_howto_table[howto_index].name, + (h) ? h->root.root.string : "a local symbol"); + bfd_set_error (bfd_error_bad_value); + return FALSE; + } + case BFD_RELOC_AARCH64_ADR_HI21_NC_PCREL: case BFD_RELOC_AARCH64_ADR_HI21_PCREL: case BFD_RELOC_AARCH64_ADR_LO21_PCREL: diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog index 203fcc5dc2a..6f5ff5e6cd9 100644 --- a/ld/testsuite/ChangeLog +++ b/ld/testsuite/ChangeLog @@ -1,3 +1,14 @@ +2014-08-26 Jiong Wang + + * ld-aarch64/copy-relocs-so.s: New test file. + * ld-aarch64/copy-relocs-exe.s: Likewise. + * ld-aarch64/copy-relocs.d: New expectation file. + * ld-aarch64/emit-relocs-264-bad.d: New test file. + * ld-aarch64/emit-relocs-266-bad.d: Likewise. + * ld-aarch64/emit-relocs-268-bad.d: Likewise. + * ld-aarch64/emit-relocs-269-bad.d: Likewise. + * ld-aarch64/aarch64-elf.exp: Run new added test. + 2014-08-26 Nick Clifton * ld-aarch64/eh-frame-foo.s: Use 8-byte offset for X30. diff --git a/ld/testsuite/ld-aarch64/aarch64-elf.exp b/ld/testsuite/ld-aarch64/aarch64-elf.exp index 36babf3b4ee..b3f6eb54541 100644 --- a/ld/testsuite/ld-aarch64/aarch64-elf.exp +++ b/ld/testsuite/ld-aarch64/aarch64-elf.exp @@ -51,11 +51,15 @@ run_dump_test "emit-relocs-260-be" run_dump_test "emit-relocs-262" run_dump_test "emit-relocs-263" run_dump_test "emit-relocs-264" +run_dump_test "emit-relocs-264-bad" run_dump_test "emit-relocs-265" run_dump_test "emit-relocs-266" +run_dump_test "emit-relocs-266-bad" run_dump_test "emit-relocs-267" run_dump_test "emit-relocs-268" +run_dump_test "emit-relocs-268-bad" run_dump_test "emit-relocs-269" +run_dump_test "emit-relocs-269-bad" run_dump_test "emit-relocs-270" run_dump_test "emit-relocs-270-bad" run_dump_test "emit-relocs-271" @@ -163,3 +167,12 @@ run_dump_test "ifunc-21" run_dump_test "ifunc-22" run_dump_test "relasz" + +set aarch64elflinktests { + {"ld-aarch64/so with global symbol" "-shared" "" "" {copy-reloc-so.s} + {} "copy-reloc-so.so"} + {"ld-aarch64/exe with copy relocation" "-e0 tmpdir/copy-reloc-so.so" "" "" + {copy-reloc-exe.s} {{objdump -R copy-reloc.d}} "copy-reloc"} +} + +run_ld_link_tests $aarch64elflinktests diff --git a/ld/testsuite/ld-aarch64/copy-reloc-exe.s b/ld/testsuite/ld-aarch64/copy-reloc-exe.s new file mode 100644 index 00000000000..cafc7006c43 --- /dev/null +++ b/ld/testsuite/ld-aarch64/copy-reloc-exe.s @@ -0,0 +1,7 @@ + .text + .global main +main: + movz x0,:abs_g0_nc:global_a + movk x0,:abs_g1_nc:global_a + movk x0,:abs_g2_nc:global_a + movk x0,:abs_g3:global_a diff --git a/ld/testsuite/ld-aarch64/copy-reloc-so.s b/ld/testsuite/ld-aarch64/copy-reloc-so.s new file mode 100644 index 00000000000..07ec44a2c7d --- /dev/null +++ b/ld/testsuite/ld-aarch64/copy-reloc-so.s @@ -0,0 +1,6 @@ + .global global_a + .type global_a, %object + .size global_a, 4 + .data +global_a: + .word 0xcafedead diff --git a/ld/testsuite/ld-aarch64/copy-reloc.d b/ld/testsuite/ld-aarch64/copy-reloc.d new file mode 100644 index 00000000000..c4eed84c092 --- /dev/null +++ b/ld/testsuite/ld-aarch64/copy-reloc.d @@ -0,0 +1,4 @@ +.* +DYNAMIC RELOCATION RECORDS +OFFSET.*TYPE.*VALUE.* +.*R_AARCH64_COPY.*global_a diff --git a/ld/testsuite/ld-aarch64/emit-relocs-264-bad.d b/ld/testsuite/ld-aarch64/emit-relocs-264-bad.d new file mode 100644 index 00000000000..22718cad609 --- /dev/null +++ b/ld/testsuite/ld-aarch64/emit-relocs-264-bad.d @@ -0,0 +1,3 @@ +#source: emit-relocs-264.s +#ld: -T relocs.ld --defsym tempy=0x11000 --defsym tempy2=0x45000 --defsym tempy3=0x1234 -e0 -shared +#error: .*relocation R_AARCH64_MOVW_UABS_G0_NC.*can not.*shared object.*fPIC diff --git a/ld/testsuite/ld-aarch64/emit-relocs-266-bad.d b/ld/testsuite/ld-aarch64/emit-relocs-266-bad.d new file mode 100644 index 00000000000..886494df51e --- /dev/null +++ b/ld/testsuite/ld-aarch64/emit-relocs-266-bad.d @@ -0,0 +1,3 @@ +#source: emit-relocs-266.s +#ld: -T relocs.ld --defsym tempy=0x11000 --defsym tempy2=0x45000 --defsym tempy3=0x1234 -e0 -shared +#error: .*relocation R_AARCH64_MOVW_UABS_G1_NC.*can not.*shared object.*fPIC diff --git a/ld/testsuite/ld-aarch64/emit-relocs-268-bad.d b/ld/testsuite/ld-aarch64/emit-relocs-268-bad.d new file mode 100644 index 00000000000..ea97541c862 --- /dev/null +++ b/ld/testsuite/ld-aarch64/emit-relocs-268-bad.d @@ -0,0 +1,3 @@ +#source: emit-relocs-268.s +#ld: -T relocs.ld --defsym tempy=0x11000 --defsym tempy2=0x45000 --defsym tempy3=0x1234 -e0 -shared +#error: .*relocation R_AARCH64_MOVW_UABS_G2_NC.*can not.*shared object.*fPIC diff --git a/ld/testsuite/ld-aarch64/emit-relocs-269-bad.d b/ld/testsuite/ld-aarch64/emit-relocs-269-bad.d new file mode 100644 index 00000000000..9292855f73a --- /dev/null +++ b/ld/testsuite/ld-aarch64/emit-relocs-269-bad.d @@ -0,0 +1,3 @@ +#source: emit-relocs-269.s +#ld: -T relocs.ld --defsym tempy=0x11000 --defsym tempy2=0x45000 --defsym tempy3=0x1234 -e0 -shared +#error: .*relocation R_AARCH64_MOVW_UABS_G3.*can not.*shared object.*fPIC -- 2.30.2