From 62a4d9428b459473bdb080c9734c1db46e87d6dd Mon Sep 17 00:00:00 2001 From: Mark Mitchell Date: Wed, 24 Nov 2004 18:10:26 +0000 Subject: [PATCH] re PR c++/18586 (ICE on invalid template member declaration) PR c++/18586 * parser.c (cp_parser_init_declarator): Do not pop scope twice. PR c++/18586 * g++.dg/template/crash27.C: New test. From-SVN: r91182 --- gcc/cp/ChangeLog | 3 +++ gcc/cp/parser.c | 5 ++++- gcc/testsuite/ChangeLog | 3 +++ gcc/testsuite/g++.dg/template/deduce3.C | 9 +++++++++ 4 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/template/deduce3.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index faf73ad89fd..abfc86abb8a 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,5 +1,8 @@ 2004-11-24 Mark Mitchell + PR c++/18586 + * parser.c (cp_parser_init_declarator): Do not pop scope twice. + PR c++/18530 * cp-tree.h (CTOR_NAME): Remove. (DTOR_NAME): Remove. diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c index 265abdb81e4..ccd8a95c434 100644 --- a/gcc/cp/parser.c +++ b/gcc/cp/parser.c @@ -10590,7 +10590,10 @@ cp_parser_init_declarator (cp_parser* parser, if (member_p) { if (pop_p) - pop_scope (scope); + { + pop_scope (scope); + pop_p = false; + } decl = grokfield (declarator, decl_specifiers, initializer, /*asmspec=*/NULL_TREE, /*attributes=*/NULL_TREE); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 03014a1ee3f..d569fb719fb 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,8 @@ 2004-11-24 Mark Mitchell + PR c++/18586 + * g++.dg/template/crash27.C: New test. + PR c++/18530 * g++.dg/warn/Wshadow-3.C: New test. diff --git a/gcc/testsuite/g++.dg/template/deduce3.C b/gcc/testsuite/g++.dg/template/deduce3.C new file mode 100644 index 00000000000..d6d68a81bc7 --- /dev/null +++ b/gcc/testsuite/g++.dg/template/deduce3.C @@ -0,0 +1,9 @@ +template +void f(int, T (*)() = 0); + +void g() { + typedef int A[2]; + f(0); // { dg-error "" } + typedef void F(); + f(0); // { dg-error "" } +} -- 2.30.2