From 640ebeb336050887cb57417b7568279c588088f0 Mon Sep 17 00:00:00 2001 From: Jonathan Wakely Date: Fri, 20 Nov 2020 11:30:33 +0000 Subject: [PATCH] libstdc++: Remove dependency from [PR 92546] Unlike the other headers that declare alias templates in namespace pmr, includes . That was done because the pmr::string::const_iterator typedef requires pmr::string to be complete, which requires pmr::polymorphic_allocator to be complete. By using __normal_iterator instead of the const_iterator typedef we can avoid the completeness requirement. This makes smaller, by not requiring and its dependency, which depends on . Backporting this will also help with PR 97876, where ends up being needed by via . libstdc++-v3/ChangeLog: PR libstdc++/92546 * include/std/regex (pmr::smatch, pmr::wsmatch): Declare using underlying __normal_iterator type, not nested typedef basic_string::const_iterator. --- libstdc++-v3/include/std/regex | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libstdc++-v3/include/std/regex b/libstdc++-v3/include/std/regex index 43ee1aee616..783f5f131a6 100644 --- a/libstdc++-v3/include/std/regex +++ b/libstdc++-v3/include/std/regex @@ -64,21 +64,25 @@ #include #if __cplusplus >= 201703L && _GLIBCXX_USE_CXX11_ABI -#include namespace std _GLIBCXX_VISIBILITY(default) { _GLIBCXX_BEGIN_NAMESPACE_VERSION - namespace pmr { + namespace pmr + { template class polymorphic_allocator; template using match_results = std::match_results<_BidirectionalIterator, polymorphic_allocator< sub_match<_BidirectionalIterator>>>; - using cmatch = match_results; - using smatch = match_results; + using cmatch = match_results; + // Use __normal_iterator directly, because pmr::string::const_iterator + // would require pmr::polymorphic_allocator to be complete. + using smatch + = match_results<__gnu_cxx::__normal_iterator>; #ifdef _GLIBCXX_USE_WCHAR_T using wcmatch = match_results; - using wsmatch = match_results; + using wsmatch + = match_results<__gnu_cxx::__normal_iterator>; #endif } // namespace pmr _GLIBCXX_END_NAMESPACE_VERSION -- 2.30.2