From 644ac2b780366582fe1fee9a677b1f6a508e65dc Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Thu, 13 Jul 2017 20:04:33 +0100 Subject: [PATCH] egl: propagate EGL_BAD_ATTRIBUTE during EGLImage attr parsing MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Earlier commit refactored/split the parsing into separate hunks. While no functional change was intended, it did not attribute that different error is set when the attrib. value is incorrect. Fixes: 3ee2be4113d ("egl: split _eglParseImageAttribList into per extension functions") Cc: Michel Dänzer Reported-by: Michel Dänzer Signed-off-by: Emil Velikov Tested-by: Michel Dänzer Reviewed-by: Eric Engestrom --- src/egl/main/eglimage.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/egl/main/eglimage.c b/src/egl/main/eglimage.c index a96075fe558..72a556e8dbd 100644 --- a/src/egl/main/eglimage.c +++ b/src/egl/main/eglimage.c @@ -302,6 +302,13 @@ _eglParseImageAttribList(_EGLImageAttribs *attrs, _EGLDisplay *dpy, if (err == EGL_SUCCESS) continue; + /* EXT_image_dma_buf_import states that if invalid value is provided for + * its attributes, we should return EGL_BAD_ATTRIBUTE. + * Bail out ASAP, since follow-up calls can return another EGL_BAD error. + */ + if (err == EGL_BAD_ATTRIBUTE) + return _eglError(err, __func__); + err = _eglParseEXTImageDmaBufImportModifiersAttribs(attrs, dpy, attr, val); if (err == EGL_SUCCESS) continue; -- 2.30.2