From 64b8feeb0e70c7e138d7e9485ccacb7fd39ae044 Mon Sep 17 00:00:00 2001 From: Nikos Nikoleris Date: Thu, 27 Jul 2017 23:36:17 +0100 Subject: [PATCH] cpu-o3: Check predication before the SQ size for a debug print The size of the store entry in the LSQ is used to indicate a fault in the execution of the store. At the same time, a store that is predicated false will also have 0 size in the corresponding store queue entry. This changeset ensures that we check if the store was predicated false before checking the size field. This way we avoid printing stores as faulting when they are only predicated false. Change-Id: Ie07982197bd73d7b44d26a3257d54ecb103a952a Reviewed-by: Andreas Sandberg Reviewed-on: https://gem5-review.googlesource.com/4821 Maintainer: Andreas Sandberg --- src/cpu/o3/lsq_unit_impl.hh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/cpu/o3/lsq_unit_impl.hh b/src/cpu/o3/lsq_unit_impl.hh index 65abaa438..ca6a7f399 100644 --- a/src/cpu/o3/lsq_unit_impl.hh +++ b/src/cpu/o3/lsq_unit_impl.hh @@ -679,18 +679,18 @@ LSQUnit::executeStore(DynInstPtr &store_inst) store_fault == NoFault) return store_fault; - if (!store_inst->readPredicate()) + if (!store_inst->readPredicate()) { + DPRINTF(LSQUnit, "Store [sn:%lli] not executed from predication\n", + store_inst->seqNum); store_inst->forwardOldRegs(); + return store_fault; + } if (storeQueue[store_idx].size == 0) { DPRINTF(LSQUnit,"Fault on Store PC %s, [sn:%lli], Size = 0\n", store_inst->pcState(), store_inst->seqNum); return store_fault; - } else if (!store_inst->readPredicate()) { - DPRINTF(LSQUnit, "Store [sn:%lli] not executed from predication\n", - store_inst->seqNum); - return store_fault; } assert(store_fault == NoFault); -- 2.30.2