From 64c03bdb6ed0b1b44ebe6f9f151fde3af83bdf38 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Wed, 7 Oct 2020 08:13:44 -0400 Subject: [PATCH] gdb: make signal_catch_counts a static array I noticed that signal_catch_counts is a dynamically-allocated array of constant size, allocated at startup an never freed. This might as well be a statically-allocated array. gdb/ChangeLog: * break-catch-sig.c (signal_catch_counts): Make a static arrray. (_initialize_break_catch_sig): Don't allocate array. Change-Id: I220321df5ad6c1d2664ec9d483eea2dc1c979afe --- gdb/ChangeLog | 5 +++++ gdb/break-catch-sig.c | 4 +--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2744ad8e097..6a69e630852 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-10-07 Simon Marchi + + * break-catch-sig.c (signal_catch_counts): Make a static arrray. + (_initialize_break_catch_sig): Don't allocate array. + 2020-10-06 Andrew Burgess * symtab.c (find_pc_line): Return unmapped addresses when the diff --git a/gdb/break-catch-sig.c b/gdb/break-catch-sig.c index e3e6f6fd8c9..5c7cdf1fecc 100644 --- a/gdb/break-catch-sig.c +++ b/gdb/break-catch-sig.c @@ -60,7 +60,7 @@ static struct breakpoint_ops signal_catchpoint_ops; /* Count of each signal. */ -static unsigned int *signal_catch_counts; +static unsigned int signal_catch_counts[GDB_SIGNAL_LAST]; @@ -430,8 +430,6 @@ _initialize_break_catch_sig () { initialize_signal_catchpoint_ops (); - signal_catch_counts = XCNEWVEC (unsigned int, GDB_SIGNAL_LAST); - add_catch_command ("signal", _("\ Catch signals by their names and/or numbers.\n\ Usage: catch signal [[NAME|NUMBER] [NAME|NUMBER]...|all]\n\ -- 2.30.2