From 64cb17196c7b2365ec152991235e686e6dc27a18 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Wed, 1 Sep 2021 10:06:08 +0930 Subject: [PATCH] PR28250, Null pointer dereference in debug_class_type_samep Typo fix, obviously should be m1->variants != NULL, not m1->variants == NULL. PR 28250 * debug.c (debug_class_type_samep): Correct m1->variants test. --- binutils/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/binutils/debug.c b/binutils/debug.c index 93887374d15..9d60d154f04 100644 --- a/binutils/debug.c +++ b/binutils/debug.c @@ -3334,7 +3334,7 @@ debug_class_type_samep (struct debug_handle *info, struct debug_type_s *t1, || strcmp (m1->name, m2->name) != 0 || (m1->variants == NULL) != (m2->variants == NULL)) return false; - if (m1->variants == NULL) + if (m1->variants != NULL) { struct debug_method_variant_s **pv1, **pv2; -- 2.30.2