From 66632539b65af333bbf3d00fde9e249f97a8ab8e Mon Sep 17 00:00:00 2001 From: Brad Beckmann Date: Mon, 22 Mar 2010 11:19:17 -0700 Subject: [PATCH] ruby: improved isReadWrite fix me comment --- src/mem/ruby/system/RubyPort.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mem/ruby/system/RubyPort.cc b/src/mem/ruby/system/RubyPort.cc index 314f551d1..480c13ad8 100644 --- a/src/mem/ruby/system/RubyPort.cc +++ b/src/mem/ruby/system/RubyPort.cc @@ -230,8 +230,10 @@ RubyPort::M5Port::recvTiming(PacketPtr pkt) type = RubyRequestType_ST; } else if (pkt->isReadWrite()) { // - // Fix me. Just because the packet is a read/write request does not - // necessary mean it is a read-modify-write atomic operation. + // Fix me. This conditional will never be executed because + // isReadWrite() is just an OR of isRead() and isWrite(). + // Furthermore, just because the packet is a read/write request does + // not necessary mean it is a read-modify-write atomic operation. // type = RubyRequestType_RMW_Write; } else { -- 2.30.2