From 66c540d27c006b338843d5243e1a3cb0dbbaf6ea Mon Sep 17 00:00:00 2001 From: Marc Glisse Date: Wed, 30 May 2012 12:48:06 +0200 Subject: [PATCH] simplify-rtx.c (simplify_binary_operation_1): Optimize shuffle of concatenations. 2012-05-30 Marc Glisse gcc/ * simplify-rtx.c (simplify_binary_operation_1): Optimize shuffle of concatenations. gcc/testsuite/ * gcc.target/i386/shuf-concat.c: New test. From-SVN: r188006 --- gcc/ChangeLog | 5 +++++ gcc/simplify-rtx.c | 23 ++++++++++++++++++++- gcc/testsuite/ChangeLog | 4 ++++ gcc/testsuite/gcc.target/i386/shuf-concat.c | 13 ++++++++++++ 4 files changed, 44 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/i386/shuf-concat.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 6c59322e7d7..f19ac409607 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2012-05-30 Marc Glisse + + * simplify-rtx.c (simplify_binary_operation_1): Optimize shuffle of + concatenations. + 2012-05-30 Richard Guenther PR middle-end/53522 diff --git a/gcc/simplify-rtx.c b/gcc/simplify-rtx.c index 6b0d56ed3ea..6b645fe027c 100644 --- a/gcc/simplify-rtx.c +++ b/gcc/simplify-rtx.c @@ -1,7 +1,7 @@ /* RTL simplification functions for GNU compiler. Copyright (C) 1987, 1988, 1989, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, - 2011 Free Software Foundation, Inc. + 2011, 2012 Free Software Foundation, Inc. This file is part of GCC. @@ -3242,6 +3242,27 @@ simplify_binary_operation_1 (enum rtx_code code, enum machine_mode mode, return gen_rtx_CONST_VECTOR (mode, v); } + + /* If we build {a,b} then permute it, build the result directly. */ + if (XVECLEN (trueop1, 0) == 2 + && CONST_INT_P (XVECEXP (trueop1, 0, 0)) + && CONST_INT_P (XVECEXP (trueop1, 0, 1)) + && GET_CODE (trueop0) == VEC_CONCAT + && GET_CODE (XEXP (trueop0, 0)) == VEC_CONCAT + && GET_MODE (XEXP (trueop0, 0)) == mode + && GET_CODE (XEXP (trueop0, 1)) == VEC_CONCAT + && GET_MODE (XEXP (trueop0, 1)) == mode) + { + unsigned int i0 = INTVAL (XVECEXP (trueop1, 0, 0)); + unsigned int i1 = INTVAL (XVECEXP (trueop1, 0, 1)); + rtx subop0, subop1; + + gcc_assert (i0 < 4 && i1 < 4); + subop0 = XEXP (XEXP (trueop0, i0 / 2), i0 % 2); + subop1 = XEXP (XEXP (trueop0, i1 / 2), i1 % 2); + + return simplify_gen_binary (VEC_CONCAT, mode, subop0, subop1); + } } if (XVECLEN (trueop1, 0) == 1 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 2f42a8e671e..b36bc06a25c 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2012-05-30 Marc Glisse + + * gcc.target/i386/shuf-concat.c: New test. + 2012-05-30 Jakub Jelinek PR rtl-optimization/53519 diff --git a/gcc/testsuite/gcc.target/i386/shuf-concat.c b/gcc/testsuite/gcc.target/i386/shuf-concat.c new file mode 100644 index 00000000000..04ed4a9dbb8 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/shuf-concat.c @@ -0,0 +1,13 @@ +/* { dg-do compile } */ +/* { dg-options "-O -msse2 -mfpmath=sse" } */ + +typedef double v2df __attribute__ ((__vector_size__ (16))); + +v2df f(double d,double e){ + v2df x={-d,d}; + v2df y={-e,e}; + return __builtin_ia32_shufpd(x,y,1); +} + +/* { dg-final { scan-assembler-not "\tv?shufpd\[ \t\]" } } */ +/* { dg-final { scan-assembler-times "\tv?unpcklpd\[ \t\]" 1 } } */ -- 2.30.2