From 66df2ffa36a69265dbb6ab815a93eca6c2a208da Mon Sep 17 00:00:00 2001 From: Rafael Antognolli Date: Wed, 24 Jun 2020 18:57:51 +0000 Subject: [PATCH] anv: Align "used" attribute to 64 bits. This is a 64 bits value that might not be aligned on 32 bit plaforms. Since it's used with atomics, let's make sure it gets properly aligned to avoid any potential performance loss. Reviewed-by: Kenneth Graunke Reviewed-by: Lionel Landwerlin Part-of: --- src/intel/vulkan/anv_private.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index a6104bdcfa1..e31e6a6579e 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_private.h @@ -1036,8 +1036,11 @@ struct anv_memory_heap { VkDeviceSize size; VkMemoryHeapFlags flags; - /* Driver-internal book-keeping */ - VkDeviceSize used; + /** Driver-internal book-keeping. + * + * Align it to 64 bits to make atomic operations faster on 32 bit platforms. + */ + VkDeviceSize used __attribute__ ((aligned (8))); }; struct anv_physical_device { -- 2.30.2