From 670cd4080b27b52df2d303d91bcccfa544c7197a Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Mon, 13 Nov 2017 14:04:59 +0000 Subject: [PATCH] egl: remove unneeded _eglGetNativePlatform check MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit There's little point in calling _eglGetNativePlatform() in eglCopyBuffers. The platform returned should be identical to the one already stored in our _EGLDisplay. In the following corner case, the check is incorrect. The function _eglGetNativePlatform effectively invokes the old-style eglGetDisplay platform selection. Thus if the EGL_PLATFORM platform does not match with the EGL_EXT_platform_* used to create the display we'll error out. Addresses the egl-copy-buffers piglit test. Signed-off-by: Emil Velikov Reviewed-by: Tapani Pälli --- src/egl/main/eglapi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index deb479b6d56..0960daccfb0 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -1394,8 +1394,6 @@ eglCopyBuffers(EGLDisplay dpy, EGLSurface surface, EGLNativePixmapType target) native_pixmap_ptr = (void*) target; _EGL_CHECK_SURFACE(disp, surf, EGL_FALSE, drv); - if (disp->Platform != _eglGetNativePlatform(disp->PlatformDisplay)) - RETURN_EGL_ERROR(disp, EGL_BAD_NATIVE_PIXMAP, EGL_FALSE); ret = drv->API.CopyBuffers(drv, disp, surf, native_pixmap_ptr); RETURN_EGL_EVAL(disp, ret); -- 2.30.2