From 67641dd326e026b84d0e4ce47f32f71132449e27 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Thu, 23 Jan 2020 11:35:51 +1030 Subject: [PATCH] PR25444, Floating point exception in _bfd_elf_compute_section_file_positions PR 25444 * elf.c (assign_file_positions_for_load_sections): Avoid divide by zero when p_align is zero. --- bfd/ChangeLog | 6 ++++++ bfd/elf.c | 16 +++++++++++----- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 635932462b8..97f5384be39 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2020-01-23 Alan Modra + + PR 25444 + * elf.c (assign_file_positions_for_load_sections): Avoid divide + by zero when p_align is zero. + 2020-01-22 Maxim Blinov * bfd/elfnn-riscv.c (riscv_skip_prefix): New. diff --git a/bfd/elf.c b/bfd/elf.c index 08aaab644a8..a8d98a60f4e 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -5755,11 +5755,17 @@ assign_file_positions_for_load_sections (bfd *abfd, { p->p_offset = off; if (no_contents) - /* Put meaningless p_offset for PT_LOAD segments - without file contents somewhere within the first - page, in an attempt to not point past EOF. */ - p->p_offset = off % (p->p_align > maxpagesize - ? p->p_align : maxpagesize); + { + /* Put meaningless p_offset for PT_LOAD segments + without file contents somewhere within the first + page, in an attempt to not point past EOF. */ + bfd_size_type align = maxpagesize; + if (align < p->p_align) + align = p->p_align; + if (align < 1) + align = 1; + p->p_offset = off % align; + } } else { -- 2.30.2