From 67a9a71183b2f51c1c96fbc5523504eb5834e44f Mon Sep 17 00:00:00 2001 From: Vineet Gupta Date: Wed, 3 Apr 2019 09:53:03 +0000 Subject: [PATCH] [ARC]PR 88409: miscompilation due to missing cc clobber in longlong.h macros simple test such as below was failing. | void main(int argc, char *argv[]) | { | size_t total_time = 115424; // expected 115.424 | double secs = (double)total_time/(double)1000; | printf("%s %d %lf\n", "secs", total_time, secs); // prints 113.504 | printf("%d\n", (size_t)secs); | } The printf eventually called into glibc stdlib/divrem.c:__mpn_divrem() which uses the __arc__ specific inline asm macros from longlong.h which were causing miscompilation. include/ 2019-03-28 Vineet Gupta PR 89877 * longlong.h [__arc__] (add_ssaaaa): Add cc clobber (sub_ddmmss): Likewise. Signed-off-by: Claudiu Zissulescu From-SVN: r270118 --- include/ChangeLog | 6 ++++++ include/longlong.h | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/include/ChangeLog b/include/ChangeLog index be08141deeb..ffa48aef7c4 100644 --- a/include/ChangeLog +++ b/include/ChangeLog @@ -1,3 +1,9 @@ +2019-04-03 Vineet Gupta + + PR89877 + * longlong.h [__arc__] (add_ssaaaa): Add cc clobber. + (sub_ddmmss): Likewise. + 2019-02-11 Philippe Waroquiers * splay-tree.h (splay_tree_delete_key_fn): Update comment. diff --git a/include/longlong.h b/include/longlong.h index 3dd8dc3aa80..1f0ce420425 100644 --- a/include/longlong.h +++ b/include/longlong.h @@ -199,7 +199,8 @@ extern UDItype __udiv_qrnnd (UDItype *, UDItype, UDItype, UDItype); : "%r" ((USItype) (ah)), \ "rICal" ((USItype) (bh)), \ "%r" ((USItype) (al)), \ - "rICal" ((USItype) (bl))) + "rICal" ((USItype) (bl)) \ + : "cc") #define sub_ddmmss(sh, sl, ah, al, bh, bl) \ __asm__ ("sub.f %1, %4, %5\n\tsbc %0, %2, %3" \ : "=r" ((USItype) (sh)), \ @@ -207,7 +208,8 @@ extern UDItype __udiv_qrnnd (UDItype *, UDItype, UDItype, UDItype); : "r" ((USItype) (ah)), \ "rICal" ((USItype) (bh)), \ "r" ((USItype) (al)), \ - "rICal" ((USItype) (bl))) + "rICal" ((USItype) (bl)) \ + : "cc") #define __umulsidi3(u,v) ((UDItype)(USItype)u*(USItype)v) #ifdef __ARC_NORM__ -- 2.30.2