From 67e49a7f6570b8691d9405cb65f263b87817fe71 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Nicolai=20H=C3=A4hnle?= Date: Tue, 6 Jun 2017 19:17:49 +0200 Subject: [PATCH] amd/common: fix off-by-one in sid_tables.py MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The very last entry in the sid_strings_offsets table ended up missing, leading to out-of-bounds reads and potential crashes. Reviewed-by: Marek Olšák --- src/amd/common/sid_tables.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/sid_tables.py b/src/amd/common/sid_tables.py index fd88d3c9d5d..0a2b7ef1fe4 100644 --- a/src/amd/common/sid_tables.py +++ b/src/amd/common/sid_tables.py @@ -110,7 +110,7 @@ class IntTable: [static] const typename name[] = { ... }; to filp. """ - idxs = sorted(self.idxs) + [-1] + idxs = sorted(self.idxs) + [len(self.table)] fragments = [ ('\t/* %s */ %s' % ( -- 2.30.2