From 67fa57cfa536cefb5ae7cc4635db66d03fdbd8bb Mon Sep 17 00:00:00 2001 From: Ulrich Weigand Date: Fri, 3 Nov 2017 16:07:23 +0100 Subject: [PATCH] Fix regression on ARM after Target FP patches Commit edd079d9f6ca2f9ad21322b742269aec5de61190 exposed a pre-existing bug in convert_doublest_to_floatformat. In the specific case of converting a zero value to a floatformat using a "special" byteorder (i.e. neither floatformat_little nor floatformat_big), the output buffer was actually left uninitialized. gdb/ChangeLog: 2017-11-03 Ulrich Weigand * doublest.c (convert_doublest_to_floatformat): Fix uninitialized output when converting a zero value to a special byteorder format. --- gdb/ChangeLog | 5 +++++ gdb/doublest.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 085b6153698..1f823ca533e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-11-03 Ulrich Weigand + + * doublest.c (convert_doublest_to_floatformat): Fix uninitialized + output when converting a zero value to a special byteorder format. + 2017-11-02 Yao Qi * frame.c (do_frame_register_read): Remove aspace. diff --git a/gdb/doublest.c b/gdb/doublest.c index fe9fc23d711..ef98dde8cbd 100644 --- a/gdb/doublest.c +++ b/gdb/doublest.c @@ -387,7 +387,7 @@ convert_doublest_to_floatformat (const struct floatformat *fmt, } if (dfrom == 0) - return; /* Result is zero */ + goto finalize_byteorder; /* Result is zero */ if (dfrom != dfrom) /* Result is NaN */ { /* From is NaN */ -- 2.30.2