From 68d8b93454c20a663d4b259919d487fe16519837 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Wed, 1 Jun 2005 15:52:45 +0000 Subject: [PATCH] re PR libgcj/21753 (String.substring sharing heuristic should be improved) PR libgcj/21753: * java/lang/natString.cc (substring): Changed sharing heuristic. From-SVN: r100454 --- libjava/ChangeLog | 5 +++++ libjava/java/lang/natString.cc | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libjava/ChangeLog b/libjava/ChangeLog index ca9f2f45fe1..cddaecbd1d9 100644 --- a/libjava/ChangeLog +++ b/libjava/ChangeLog @@ -1,3 +1,8 @@ +2005-06-01 Tom Tromey + + PR libgcj/21753: + * java/lang/natString.cc (substring): Changed sharing heuristic. + 2005-05-30 Bryce McKinlay PR libgcj/21821 diff --git a/libjava/java/lang/natString.cc b/libjava/java/lang/natString.cc index a14f5de9d6e..c8f3129a212 100644 --- a/libjava/java/lang/natString.cc +++ b/libjava/java/lang/natString.cc @@ -833,7 +833,10 @@ java::lang::String::substring (jint beginIndex, jint endIndex) if (beginIndex == 0 && endIndex == count) return this; jint newCount = endIndex - beginIndex; - if (newCount <= 8) // Optimization, mainly for GC. + // For very small strings, just allocate a new one. For other + // substrings, allocate a new one unless the substring is over half + // of the original string. + if (newCount <= 8 || newCount < (count >> 1)) return JvNewString(JvGetStringChars(this) + beginIndex, newCount); jstring s = new String(); s->data = data; -- 2.30.2