From 6944d9ddb0be2b586fb48eece8591bb62a5d5b66 Mon Sep 17 00:00:00 2001 From: Steven Bosscher Date: Mon, 17 May 2004 21:25:32 +0000 Subject: [PATCH] tree-ssa-operands.c (get_expr_operands): Do not treat malloc attributed functions as pure or const. * tree-ssa-operands.c (get_expr_operands): Do not treat malloc attributed functions as pure or const. From-SVN: r81951 --- gcc/ChangeLog | 5 +++++ gcc/testsuite/ChangeLog | 4 ++++ gcc/testsuite/gcc.dg/tree-ssa/20040517-1.c | 20 ++++++++++++++++++++ gcc/tree-ssa-operands.c | 9 ++++----- 4 files changed, 33 insertions(+), 5 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/20040517-1.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index db93d50c46d..ea3b7f97897 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2004-05-17 Steven Bosscher + + * tree-ssa-operands.c (get_expr_operands): Do not treat malloc + attributed functions as pure or const. + 2004-05-17 Frank Ch. Eigler * tree-mudflap.c (mx_register_decls): Tolerate decl trees resulting diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index ad748bcee66..82a596b454a 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2004-05-17 Steven Bosscher + + * gcc.dg/tree-ssa/20040517-1.c: New test. + 2004-05-15 Andrew Pinski * gcc.dg/tree-ssa/20040514-1.c: Add '}' that was forgotten. diff --git a/gcc/testsuite/gcc.dg/tree-ssa/20040517-1.c b/gcc/testsuite/gcc.dg/tree-ssa/20040517-1.c new file mode 100644 index 00000000000..c38f1b360f1 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/20040517-1.c @@ -0,0 +1,20 @@ +/* { dg-do compile } */ +/* { dg-options "-O1 -fdump-tree-ssa-vops" } */ +int a; + +extern void __attribute__ ((malloc)) *foo (); + +void bar (void) +{ + a = 1; + foo (); + if (a) + abort (); +} + +/* We used to treat malloc functions like pure and const functions, but + malloc functions may clobber global memory. Only the function result + does not alias any other pointer. + Hence, we must have a VDEF for a before and after the call to foo(). */ +/* { dg-final { scan-tree-dump-times "VDEF" 2 "ssa"} } */ + diff --git a/gcc/tree-ssa-operands.c b/gcc/tree-ssa-operands.c index de5b16d1fd4..f0112755d96 100644 --- a/gcc/tree-ssa-operands.c +++ b/gcc/tree-ssa-operands.c @@ -1023,12 +1023,11 @@ get_expr_operands (tree stmt, tree *expr_p, int flags, voperands_t prev_vops) if (bitmap_first_set_bit (call_clobbered_vars) >= 0) { + /* A 'pure' or a 'const' functions never call clobber anything. + A 'noreturn' function might, but since we don't return anyway + there is no point in recording that. */ if (!(call_flags - & (ECF_PURE - | ECF_CONST - | ECF_NORETURN - | ECF_MALLOC - | ECF_MAY_BE_ALLOCA))) + & (ECF_PURE | ECF_CONST | ECF_NORETURN))) add_call_clobber_ops (stmt, prev_vops); else if (!(call_flags & (ECF_CONST | ECF_NORETURN))) add_call_read_ops (stmt, prev_vops); -- 2.30.2