From 69fc7a2c828adbb454072d386a26b568e56dd886 Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Fri, 10 Feb 2017 14:03:51 +1000 Subject: [PATCH] tgsi: fix memory leak in tgsi sanity check MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This just fixes this without repeating the code. Reported-by: Li Qiang Cc: "17.0" Reviewed-by: Nicolai Hähnle Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_sanity.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_sanity.c b/src/gallium/auxiliary/tgsi/tgsi_sanity.c index f867925ef58..239a2c93835 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_sanity.c +++ b/src/gallium/auxiliary/tgsi/tgsi_sanity.c @@ -559,6 +559,7 @@ tgsi_sanity_check( const struct tgsi_token *tokens ) { struct sanity_check_ctx ctx; + boolean retval; ctx.iter.prolog = prolog; ctx.iter.iterate_instruction = iter_instruction; @@ -580,11 +581,12 @@ tgsi_sanity_check( ctx.implied_array_size = 0; ctx.print = debug_get_option_print_sanity(); - if (!tgsi_iterate_shader( tokens, &ctx.iter )) - return FALSE; - + retval = tgsi_iterate_shader( tokens, &ctx.iter ); regs_hash_destroy(ctx.regs_decl); regs_hash_destroy(ctx.regs_used); regs_hash_destroy(ctx.regs_ind_used); + if (retval == FALSE) + return FALSE; + return ctx.errors == 0; } -- 2.30.2