From 6a245c05be60e19ab349077601ddc9ae51324423 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Tue, 27 Sep 2016 10:15:26 +0200 Subject: [PATCH] combine.c (simplify_comparison): Add canonical FALLTHROUGH comments. * combine.c (simplify_comparison): Add canonical FALLTHROUGH comments. * config/i386/i386.c (ix86_dep_by_shift_count_body): Add FALLTHROUGH comments. Remove break after return. (ix86_fp_compare_code_to_integer, has_dispatch, ix86_simd_clone_usable): Remove break after return. From-SVN: r240523 --- gcc/ChangeLog | 8 ++++++++ gcc/combine.c | 6 +++--- gcc/config/i386/i386.c | 11 ++--------- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index fa647886249..1a2d42fe96f 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2016-09-27 Jakub Jelinek + + * combine.c (simplify_comparison): Add canonical FALLTHROUGH comments. + * config/i386/i386.c (ix86_dep_by_shift_count_body): Add FALLTHROUGH + comments. Remove break after return. + (ix86_fp_compare_code_to_integer, has_dispatch, + ix86_simd_clone_usable): Remove break after return. + 2016-09-27 Bernd Edlinger PR rlt-optimization/77714 diff --git a/gcc/combine.c b/gcc/combine.c index b22a2748029..b27aae5f02f 100644 --- a/gcc/combine.c +++ b/gcc/combine.c @@ -11923,11 +11923,11 @@ simplify_comparison (enum rtx_code code, rtx *pop0, rtx *pop1) we can treat the SUBREG as if it were a ZERO_EXTEND. */ if (subreg_lowpart_p (op0) && GET_MODE_PRECISION (GET_MODE (SUBREG_REG (op0))) < mode_width) - /* Fall through */ ; + ; else break; - /* ... fall through ... */ + /* FALLTHROUGH */ case ZERO_EXTEND: mode = GET_MODE (XEXP (op0, 0)); @@ -12339,7 +12339,7 @@ simplify_comparison (enum rtx_code code, rtx *pop0, rtx *pop1) continue; } - /* ... fall through ... */ + /* FALLTHROUGH */ case LSHIFTRT: /* If we have (compare (xshiftrt FOO N) (const_int C)) and the low order N bits of FOO are known to be zero, we can do this diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 256893b34d3..e0b2d5703be 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -21238,9 +21238,9 @@ ix86_dep_by_shift_count_body (const_rtx set_body, const_rtx use_body) if (ix86_dep_by_shift_count_body (XVECEXP (set_body, 0, i), use_body)) return true; + /* FALLTHROUGH */ default: return false; - break; } /* Retrieve shift count of USE_BODY. */ @@ -21254,9 +21254,9 @@ ix86_dep_by_shift_count_body (const_rtx set_body, const_rtx use_body) if (ix86_dep_by_shift_count_body (set_body, XVECEXP (use_body, 0, i))) return true; + /* FALLTHROUGH */ default: return false; - break; } if (shift_rtx @@ -22370,19 +22370,14 @@ ix86_fp_compare_code_to_integer (enum rtx_code code) case ORDERED: case UNORDERED: return code; - break; case UNEQ: return EQ; - break; case UNLT: return LTU; - break; case UNLE: return LEU; - break; case LTGT: return NE; - break; default: return UNKNOWN; } @@ -49501,7 +49496,6 @@ has_dispatch (rtx_insn *insn, int action) case IS_DISPATCH_ON: return true; - break; case IS_CMP: return is_cmp (insn); @@ -49959,7 +49953,6 @@ ix86_simd_clone_usable (struct cgraph_node *node) if (!TARGET_AVX) return -1; return TARGET_AVX2 ? 1 : 0; - break; case 'd': if (!TARGET_AVX2) return -1; -- 2.30.2