From 6a41a52e625537d1072c4f605fb1ed651ac0b99d Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Wed, 11 Oct 2017 12:10:08 -0700 Subject: [PATCH] compiler/blob: Make some parameters void instead of uint8_t MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit There are certain advantages to using uint8_t internally such as well-defined arithmetic on all platforms. However, interfaces that work in terms of raw data should use a void* type. Reviewed-by: Nicolai Hähnle Reviewed-by: Jordan Justen --- src/compiler/blob.c | 6 +++--- src/compiler/blob.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/compiler/blob.c b/src/compiler/blob.c index 5c94beed842..f0fa85e5beb 100644 --- a/src/compiler/blob.c +++ b/src/compiler/blob.c @@ -238,7 +238,7 @@ blob_write_string(struct blob *blob, const char *str) } void -blob_reader_init(struct blob_reader *blob, const uint8_t *data, size_t size) +blob_reader_init(struct blob_reader *blob, const void *data, size_t size) { blob->data = data; blob->end = blob->data + size; @@ -280,9 +280,9 @@ blob_read_bytes(struct blob_reader *blob, size_t size) } void -blob_copy_bytes(struct blob_reader *blob, uint8_t *dest, size_t size) +blob_copy_bytes(struct blob_reader *blob, void *dest, size_t size) { - const uint8_t *bytes; + const void *bytes; bytes = blob_read_bytes(blob, size); if (bytes == NULL) diff --git a/src/compiler/blob.h b/src/compiler/blob.h index e224dbbece0..f0f28ec5fa7 100644 --- a/src/compiler/blob.h +++ b/src/compiler/blob.h @@ -272,7 +272,7 @@ blob_write_string(struct blob *blob, const char *str); * current value is unchanged before and after the call. */ void -blob_reader_init(struct blob_reader *blob, const uint8_t *data, size_t size); +blob_reader_init(struct blob_reader *blob, const void *data, size_t size); /** * Read some unstructured, fixed-size data from the current location, (and @@ -292,7 +292,7 @@ blob_read_bytes(struct blob_reader *blob, size_t size); * it to \dest (and update the current location to just past this data) */ void -blob_copy_bytes(struct blob_reader *blob, uint8_t *dest, size_t size); +blob_copy_bytes(struct blob_reader *blob, void *dest, size_t size); /** * Read a uint32_t from the current location, (and update the current location -- 2.30.2