From 6af14d3685fac433193b92f9ad6c9f8a3eaf87ff Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Thu, 13 Feb 2020 17:12:51 -0500 Subject: [PATCH] pan/midgard: Don't crash with constants on unknown ops Just use a dummy name instead.. we can't know a priori what type an unknown op will consume, but we don't want to dereference a null pointer. Signed-off-by: Alyssa Rosenzweig Fixes: 24360966ab3 ("panfrost/midgard: Prettify embedded constant prints") Part-of: --- src/panfrost/midgard/midgard_print.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/panfrost/midgard/midgard_print.c b/src/panfrost/midgard/midgard_print.c index 85a1d981722..94a0f1a6453 100644 --- a/src/panfrost/midgard/midgard_print.c +++ b/src/panfrost/midgard/midgard_print.c @@ -110,6 +110,10 @@ mir_print_constant_component(FILE *fp, const midgard_constants *consts, unsigned bool is_sint = false, is_uint = false, is_hex = false; const char *opname = alu_opcode_props[op].name; + /* Add a sentinel name to prevent crashing */ + if (!opname) + opname = "unknown"; + if (opname[0] == 'u') { /* If the opcode starts with a 'u' we are sure we deal with an * unsigned int operation -- 2.30.2