From 6b2d86bda4d98894598f17fb8682e7cd4eafd833 Mon Sep 17 00:00:00 2001 From: Michael Snyder Date: Wed, 22 Aug 2007 01:57:05 +0000 Subject: [PATCH] 2007-08-21 Michael Snyder * dbxread.c (read_dbx_symtab): Guard null deref. Break up long line. --- gdb/ChangeLog | 3 +++ gdb/dbxread.c | 14 ++++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8c6751b0447..84cc94decbd 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,8 @@ 2007-08-21 Michael Snyder + * dbxread.c (read_dbx_symtab): Guard null deref. + Break up long line. + * valops.c (find_overload_match): Guard against NULL. 2007-08-21 Daniel Jacobowitz diff --git a/gdb/dbxread.c b/gdb/dbxread.c index bba9995a5e2..f66c22fa5c9 100644 --- a/gdb/dbxread.c +++ b/gdb/dbxread.c @@ -1828,7 +1828,8 @@ read_dbx_symtab (struct objfile *objfile) function_outside_compilation_unit_complaint (name); xfree (name); } - nlist.n_value += ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile)); + nlist.n_value += ANOFFSET (objfile->section_offsets, + SECT_OFF_TEXT (objfile)); /* Kludges for ELF/STABS with Sun ACC */ last_function_name = namestring; #ifdef SOFUN_ADDRESS_MAYBE_MISSING @@ -1838,7 +1839,9 @@ read_dbx_symtab (struct objfile *objfile) SECT_OFF_TEXT (objfile))) { CORE_ADDR minsym_valu = - find_stab_function_addr (namestring, pst->filename, objfile); + find_stab_function_addr (namestring, + pst ? pst->filename : NULL, + objfile); /* find_stab_function_addr will return 0 if the minimal symbol wasn't found. (Unfortunately, this might also be a valid address.) Anyway, if it *does* return 0, @@ -1893,7 +1896,8 @@ read_dbx_symtab (struct objfile *objfile) function_outside_compilation_unit_complaint (name); xfree (name); } - nlist.n_value += ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile)); + nlist.n_value += ANOFFSET (objfile->section_offsets, + SECT_OFF_TEXT (objfile)); /* Kludges for ELF/STABS with Sun ACC */ last_function_name = namestring; #ifdef SOFUN_ADDRESS_MAYBE_MISSING @@ -1903,7 +1907,9 @@ read_dbx_symtab (struct objfile *objfile) SECT_OFF_TEXT (objfile))) { CORE_ADDR minsym_valu = - find_stab_function_addr (namestring, pst->filename, objfile); + find_stab_function_addr (namestring, + pst ? pst->filename : NULL, + objfile); /* find_stab_function_addr will return 0 if the minimal symbol wasn't found. (Unfortunately, this might also be a valid address.) Anyway, if it *does* return 0, -- 2.30.2