From 6c23308e70c4323d4c99e27e0896f4eb33f69714 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Fri, 29 Aug 2014 03:06:15 +0000 Subject: [PATCH] compiler: Fix comparison of struct/array with interface. The compiler used to crash when the struct/array was not addressable. The test case is https://codereview.appspot.com/135170043 . This fixes http://golang.org/issue/8612 . From-SVN: r214713 --- gcc/go/gofrontend/expressions.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gcc/go/gofrontend/expressions.cc b/gcc/go/gofrontend/expressions.cc index f7a3c57bcb3..6414136fed0 100644 --- a/gcc/go/gofrontend/expressions.cc +++ b/gcc/go/gofrontend/expressions.cc @@ -5187,10 +5187,13 @@ Binary_expression::do_lower(Gogo* gogo, Named_object*, // Lower struct, array, and some interface comparisons. if (op == OPERATOR_EQEQ || op == OPERATOR_NOTEQ) { - if (left->type()->struct_type() != NULL) + if (left->type()->struct_type() != NULL + && right->type()->struct_type() != NULL) return this->lower_struct_comparison(gogo, inserter); else if (left->type()->array_type() != NULL - && !left->type()->is_slice_type()) + && !left->type()->is_slice_type() + && right->type()->array_type() != NULL + && !right->type()->is_slice_type()) return this->lower_array_comparison(gogo, inserter); else if ((left->type()->interface_type() != NULL && right->type()->interface_type() == NULL) -- 2.30.2