From 6c282c14d1be0bba2bf5d49acd074b349f28ad17 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Fri, 6 Nov 2020 20:33:39 +0100 Subject: [PATCH] c++: Propagate attributes to clones in duplicate_decls [PR67453] On the following testcase where the cdtor attributes aren't on the in-class declaration but on an out-of-class definition, the cdtors have their clones created from the in-class declaration, and later on duplicate_decls updates attributes on the abstract cdtors, but nothing propagates them to the clones. 2020-11-06 Jakub Jelinek PR c++/67453 * decl.c (duplicate_decls): Propagate DECL_ATTRIBUTES and DECL_PRESERVE_P from olddecl to its clones if any. * g++.dg/ext/attr-used-2.C: New test. --- gcc/cp/decl.c | 10 ++++++++++ gcc/testsuite/g++.dg/ext/attr-used-2.C | 15 +++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 gcc/testsuite/g++.dg/ext/attr-used-2.C diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c index 56bd772d01d..62648841ac3 100644 --- a/gcc/cp/decl.c +++ b/gcc/cp/decl.c @@ -2921,6 +2921,16 @@ duplicate_decls (tree newdecl, tree olddecl, bool hiding, bool was_hidden) snode->remove (); } + if (TREE_CODE (olddecl) == FUNCTION_DECL) + { + tree clone; + FOR_EACH_CLONE (clone, olddecl) + { + DECL_ATTRIBUTES (clone) = DECL_ATTRIBUTES (olddecl); + DECL_PRESERVE_P (clone) |= DECL_PRESERVE_P (olddecl); + } + } + /* Remove the associated constraints for newdecl, if any, before reclaiming memory. */ if (flag_concepts) diff --git a/gcc/testsuite/g++.dg/ext/attr-used-2.C b/gcc/testsuite/g++.dg/ext/attr-used-2.C new file mode 100644 index 00000000000..d7cf6e975bd --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/attr-used-2.C @@ -0,0 +1,15 @@ +// PR c++/67453 +// { dg-do compile } +// { dg-final { scan-assembler "_ZN1SC\[12]Ev" } } +// { dg-final { scan-assembler "_ZN1SD\[12]Ev" } } +// { dg-final { scan-assembler "_ZN1SC\[12]ERKS_" } } + +struct S { + S(); + ~S(); + S(const S&); +}; + +__attribute__((used)) inline S::S() { } +__attribute__((used)) inline S::~S() { } +__attribute__((used)) inline S::S(const S&) { } -- 2.30.2