From 6c334754244f11a1bfc01b9009c55ee5916f7dc7 Mon Sep 17 00:00:00 2001 From: Tilman Sauerbeck Date: Wed, 28 Jun 2006 16:26:20 +0000 Subject: [PATCH] propagate errors from parse_generic_attrib_num in parse_attrib_binding (-> don't segfault when you're trying to access invalid generic attributes --- src/mesa/shader/arbprogparse.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/shader/arbprogparse.c b/src/mesa/shader/arbprogparse.c index 66ea96b4d38..12db64612ee 100644 --- a/src/mesa/shader/arbprogparse.c +++ b/src/mesa/shader/arbprogparse.c @@ -1536,7 +1536,10 @@ parse_attrib_binding(GLcontext * ctx, GLubyte ** inst, case VERTEX_ATTRIB_GENERIC: { GLuint attrib; - if (!parse_generic_attrib_num(ctx, inst, Program, &attrib)) { + + err = parse_generic_attrib_num(ctx, inst, Program, &attrib); + + if (!err) { *is_generic = 1; /* Add VERT_ATTRIB_GENERIC0 here because ARB_vertex_program's * attributes do not alias the conventional vertex @@ -1556,7 +1559,6 @@ parse_attrib_binding(GLcontext * ctx, GLubyte ** inst, } } - /* Can this even happen? */ if (err) { const char *msg = "Bad attribute binding"; _mesa_set_program_error(ctx, Program->Position, msg); -- 2.30.2