From 6cf43433750bbd2837c526e03283f126a6d2c6e6 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Wed, 27 Jan 2021 10:21:03 +0100 Subject: [PATCH] testsuite: Fix TBAA in {sse,avx}*and*p[sd]*.c tests This patch drops the no-strict-aliasing hack in m128-check.h and instead ensures the tests read objects with the right dynamic type. 2021-01-27 Jakub Jelinek * gcc.target/i386/m128-check.h (CHECK_EXP): Remove optimize ("no-strict-aliasing") attribute. * gcc.target/i386/sse-andnps-1.c (TEST): Copy e into float[4] array to avoid violating TBAA. * gcc.target/i386/sse2-andpd-1.c (TEST): Copy e.d into double[2] array to avoid violating TBAA. * gcc.target/i386/sse-andps-1.c (TEST): Copy e.f into float[4] array to avoid violating TBAA. * gcc.target/i386/sse2-andnpd-1.c (TEST): Copy e into double[2] array to avoid violating TBAA. --- gcc/testsuite/gcc.target/i386/m128-check.h | 1 - gcc/testsuite/gcc.target/i386/sse-andnps-1.c | 4 +++- gcc/testsuite/gcc.target/i386/sse-andps-1.c | 4 +++- gcc/testsuite/gcc.target/i386/sse2-andnpd-1.c | 4 +++- gcc/testsuite/gcc.target/i386/sse2-andpd-1.c | 4 +++- 5 files changed, 12 insertions(+), 5 deletions(-) diff --git a/gcc/testsuite/gcc.target/i386/m128-check.h b/gcc/testsuite/gcc.target/i386/m128-check.h index 672ce961566..c468eac6a13 100644 --- a/gcc/testsuite/gcc.target/i386/m128-check.h +++ b/gcc/testsuite/gcc.target/i386/m128-check.h @@ -78,7 +78,6 @@ typedef union #define CHECK_EXP(UNION_TYPE, VALUE_TYPE, FMT) \ static int \ -__attribute__((optimize ("no-strict-aliasing"))) \ __attribute__((noinline, unused)) \ check_##UNION_TYPE (UNION_TYPE u, const VALUE_TYPE *v) \ { \ diff --git a/gcc/testsuite/gcc.target/i386/sse-andnps-1.c b/gcc/testsuite/gcc.target/i386/sse-andnps-1.c index eeeec020a7d..9a3b7faf24e 100644 --- a/gcc/testsuite/gcc.target/i386/sse-andnps-1.c +++ b/gcc/testsuite/gcc.target/i386/sse-andnps-1.c @@ -28,6 +28,7 @@ TEST (void) int source1[4]={34, 545, 955, 67}; int source2[4]={67, 4, 57, 897}; int e[4]; + float f[4]; s1.x = _mm_loadu_ps ((float *)source1); s2.x = _mm_loadu_ps ((float *)source2); @@ -37,7 +38,8 @@ TEST (void) e[1] = (~source1[1]) & source2[1]; e[2] = (~source1[2]) & source2[2]; e[3] = (~source1[3]) & source2[3]; + __builtin_memcpy (f, e, sizeof (f)); - if (check_union128 (u, (float *)e)) + if (check_union128 (u, f)) abort (); } diff --git a/gcc/testsuite/gcc.target/i386/sse-andps-1.c b/gcc/testsuite/gcc.target/i386/sse-andps-1.c index 6094dba7d34..e3d3419e497 100644 --- a/gcc/testsuite/gcc.target/i386/sse-andps-1.c +++ b/gcc/testsuite/gcc.target/i386/sse-andps-1.c @@ -30,6 +30,7 @@ TEST (void) float f[4]; int i[4]; }source1, source2, e; + float f[4]; s1.x = _mm_set_ps (34, 545, 955, 67); s2.x = _mm_set_ps (67, 4, 57, 897); @@ -43,7 +44,8 @@ TEST (void) e.i[1] = source1.i[1] & source2.i[1]; e.i[2] = source1.i[2] & source2.i[2]; e.i[3] = source1.i[3] & source2.i[3]; + __builtin_memcpy (f, e.f, sizeof (f)); - if (check_union128 (u, e.f)) + if (check_union128 (u, f)) abort (); } diff --git a/gcc/testsuite/gcc.target/i386/sse2-andnpd-1.c b/gcc/testsuite/gcc.target/i386/sse2-andnpd-1.c index 0250d6be10e..23eabab504f 100644 --- a/gcc/testsuite/gcc.target/i386/sse2-andnpd-1.c +++ b/gcc/testsuite/gcc.target/i386/sse2-andnpd-1.c @@ -28,6 +28,7 @@ TEST (void) long long source1[2]={34545, 95567}; long long source2[2]={674, 57897}; long long e[2]; + double d[2]; s1.x = _mm_loadu_pd ((double *)source1); s2.x = _mm_loadu_pd ((double *)source2); @@ -35,7 +36,8 @@ TEST (void) e[0] = (~source1[0]) & source2[0]; e[1] = (~source1[1]) & source2[1]; + __builtin_memcpy (d, e, sizeof (d)); - if (check_union128d (u, (double *)e)) + if (check_union128d (u, d)) abort (); } diff --git a/gcc/testsuite/gcc.target/i386/sse2-andpd-1.c b/gcc/testsuite/gcc.target/i386/sse2-andpd-1.c index 9f037ab5fb0..0ea4267a8fd 100644 --- a/gcc/testsuite/gcc.target/i386/sse2-andpd-1.c +++ b/gcc/testsuite/gcc.target/i386/sse2-andpd-1.c @@ -31,6 +31,7 @@ TEST (void) double d[2]; long long ll[2]; }source1, source2, e; + double d[2]; s1.x = _mm_set_pd (34545, 95567); s2.x = _mm_set_pd (674, 57897); @@ -42,7 +43,8 @@ TEST (void) e.ll[0] = source1.ll[0] & source2.ll[0]; e.ll[1] = source1.ll[1] & source2.ll[1]; + __builtin_memcpy (d, e.d, sizeof (d)); - if (check_union128d (u, e.d)) + if (check_union128d (u, d)) abort (); } -- 2.30.2