From 6db3031e5c8bbe94e2111633273d8e69e724220a Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Sat, 27 Jun 2020 14:38:43 -0400 Subject: [PATCH] gdbsupport: add format attribute to print_xml_feature::add_line Fixes this clang error: CXX tdesc.o /home/smarchi/src/binutils-gdb/gdbsupport/tdesc.cc:444:25: error: format string is not a string literal [-Werror,-Wformat-nonliteral] string_vappendf (tmp, fmt, ap); ^~~ There is already a but about GCC not emitting this warning: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82206 gdbsupport/ChangeLog: * tdesc.h (class print_xml_feature) : Add ATTRIBUTE_PRINTF. Change-Id: I7014075e83717f6d7e19d044a3675ff9981ebe17 --- gdbsupport/ChangeLog | 5 +++++ gdbsupport/tdesc.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog index b2fbc56b1b9..4db482b1519 100644 --- a/gdbsupport/ChangeLog +++ b/gdbsupport/ChangeLog @@ -1,3 +1,8 @@ +2020-06-27 Simon Marchi + + * tdesc.h (class print_xml_feature) : Add + ATTRIBUTE_PRINTF. + 2020-06-23 Andrew Burgess * tdesc.cc (print_xml_feature::visit_pre): Use add_line to add diff --git a/gdbsupport/tdesc.h b/gdbsupport/tdesc.h index 73caf24536f..456e8e070b1 100644 --- a/gdbsupport/tdesc.h +++ b/gdbsupport/tdesc.h @@ -438,7 +438,7 @@ private: functions appends a newline, so don't include one in the strings being passed. */ void add_line (const std::string &str); - void add_line (const char *fmt, ...); + void add_line (const char *fmt, ...) ATTRIBUTE_PRINTF (2, 3); /* The buffer we are writing too. */ std::string *m_buffer; -- 2.30.2