From 6e1453f681aeec2ef6e3d4fb42f10df9da2a8cd2 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Fri, 31 Aug 2018 09:40:54 -0700 Subject: [PATCH] gas/elf/section14.d: Change skip to xfail We will get an XPASS when h8300 port peculiarities are fixed, and will fix the testsuite too. * testsuite/gas/elf/section14.d: Change skip to xfail. * testsuite/lib/gas-defs.exp (run_dump_test): Add xfail support. --- gas/ChangeLog | 5 +++++ gas/testsuite/gas/elf/section14.d | 2 +- gas/testsuite/lib/gas-defs.exp | 10 ++++++++++ 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index 83249990b83..1862390026b 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,8 @@ +2018-08-31 H.J. Lu + + * testsuite/gas/elf/section14.d: Change skip to xfail. + * testsuite/lib/gas-defs.exp (run_dump_test): Add xfail support. + 2018-08-31 Alan Modra * config/tc-ppc.h (TC_FORCE_RELOCATION_SUB_LOCAL): Allow ADDR16 diff --git a/gas/testsuite/gas/elf/section14.d b/gas/testsuite/gas/elf/section14.d index d4fafa2b1db..7c730880aaa 100644 --- a/gas/testsuite/gas/elf/section14.d +++ b/gas/testsuite/gas/elf/section14.d @@ -3,7 +3,7 @@ #readelf: -S --wide # The h8300 port issues a warning message for new sections created # without atrributes. -#skip: h8300-* +#xfail: h8300-* There are [0-9]+ section headers, starting at offset 0x[0-9a-f]+: diff --git a/gas/testsuite/lib/gas-defs.exp b/gas/testsuite/lib/gas-defs.exp index 064b8668a0b..22984c70e1f 100644 --- a/gas/testsuite/lib/gas-defs.exp +++ b/gas/testsuite/lib/gas-defs.exp @@ -408,6 +408,10 @@ proc run_dump_tests { testcases {extra_options {}} } { # expected output on some targets. (For example, see # gas/arm/inst.d and gas/arm/wince_inst.d.) # +# xfail: GLOB|PROC ... +# Run this test and it is is expected to fail on a specified list +# of targets. +# # error: REGEX # An error with message matching REGEX must be emitted for the test # to pass. The PROG, objdump, nm and objcopy options have no @@ -475,6 +479,7 @@ proc run_dump_test { name {extra_options {}} } { set opts(not-target) {} set opts(skip) {} set opts(not-skip) {} + set opts(xfail) {} set opts(section-subst) {} foreach i $opt_array { @@ -619,6 +624,11 @@ proc run_dump_test { name {extra_options {}} } { } } + # Setup xfailures. + foreach targ $opts(xfail) { + setup_xfail $targ + } + if { $opts(source) == "" } { set sourcefile ${file}.s } else { -- 2.30.2