From 6e2e575a032dfc4f6a3c88dfc71282bf38cd8890 Mon Sep 17 00:00:00 2001 From: Jonathan Wakely Date: Mon, 24 Apr 2017 12:40:07 +0100 Subject: [PATCH] PR libstdc++/80504 qualify calls to avoid ADL PR libstdc++/80504 * include/bits/refwrap.h (ref, cref): Qualify calls. * testsuite/20_util/reference_wrapper/80504.cc: New test. From-SVN: r247094 --- libstdc++-v3/ChangeLog | 4 +++ libstdc++-v3/include/bits/refwrap.h | 8 ++--- .../20_util/reference_wrapper/80504.cc | 34 +++++++++++++++++++ 3 files changed, 42 insertions(+), 4 deletions(-) create mode 100644 libstdc++-v3/testsuite/20_util/reference_wrapper/80504.cc diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 6330a490972..f2d139accf5 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,5 +1,9 @@ 2017-04-24 Jonathan Wakely + PR libstdc++/80504 + * include/bits/refwrap.h (ref, cref): Qualify calls. + * testsuite/20_util/reference_wrapper/80504.cc: New test. + PR libstdc++/80493 * include/experimental/optional (optional::swap): Fix exception specification. diff --git a/libstdc++-v3/include/bits/refwrap.h b/libstdc++-v3/include/bits/refwrap.h index 124ee97bd2a..786087e8d8f 100644 --- a/libstdc++-v3/include/bits/refwrap.h +++ b/libstdc++-v3/include/bits/refwrap.h @@ -361,17 +361,17 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template void cref(const _Tp&&) = delete; - /// Partial specialization. + /// std::ref overload to prevent wrapping a reference_wrapper template inline reference_wrapper<_Tp> ref(reference_wrapper<_Tp> __t) noexcept - { return ref(__t.get()); } + { return __t; } - /// Partial specialization. + /// std::cref overload to prevent wrapping a reference_wrapper template inline reference_wrapper cref(reference_wrapper<_Tp> __t) noexcept - { return cref(__t.get()); } + { return { __t.get() }; } // @} group functors diff --git a/libstdc++-v3/testsuite/20_util/reference_wrapper/80504.cc b/libstdc++-v3/testsuite/20_util/reference_wrapper/80504.cc new file mode 100644 index 00000000000..727a560cd17 --- /dev/null +++ b/libstdc++-v3/testsuite/20_util/reference_wrapper/80504.cc @@ -0,0 +1,34 @@ +// Copyright (C) 2017 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// { dg-do compile { target c++11 } } + +#include + +namespace X { + struct Y { }; + template void ref(T) { } + template void cref(T) { } +} + +int main() +{ + X::Y i; + std::reference_wrapper r(i); + ref(r); + cref(r); +} -- 2.30.2