From 702adbb2fff0cc043f9c4e1af890421cb238cd18 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Wed, 13 May 2020 10:18:45 -0700 Subject: [PATCH] libbacktrace: treat EACCESS like ENOENT libbacktrace/ PR go/95061 * posix.c (backtrace_open): Treat EACCESS like ENOENT. --- libbacktrace/ChangeLog | 6 ++++++ libbacktrace/posix.c | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/libbacktrace/ChangeLog b/libbacktrace/ChangeLog index 9668906d20f..89b690d415e 100644 --- a/libbacktrace/ChangeLog +++ b/libbacktrace/ChangeLog @@ -1,3 +1,9 @@ +2020-05-13 Ian Lance Taylor + + PR go/95061 + * posix.c (backtrace_open): Treat EACCESS like ENOENT. + +2020-05-12 H.J. Lu * Makefile.am (AM_CFLAGS): Add $(CET_HOST_FLAGS). * configure.ac: Add GCC_CET_HOST_FLAGS(CET_HOST_FLAGS) and diff --git a/libbacktrace/posix.c b/libbacktrace/posix.c index 356e72b4a3b..a2c88dd8e4a 100644 --- a/libbacktrace/posix.c +++ b/libbacktrace/posix.c @@ -67,7 +67,11 @@ backtrace_open (const char *filename, backtrace_error_callback error_callback, descriptor = open (filename, (int) (O_RDONLY | O_BINARY | O_CLOEXEC)); if (descriptor < 0) { - if (does_not_exist != NULL && errno == ENOENT) + /* If DOES_NOT_EXIST is not NULL, then don't call ERROR_CALLBACK + if the file does not exist. We treat lacking permission to + open the file as the file not existing; this case arises when + running the libgo syscall package tests as root. */ + if (does_not_exist != NULL && (errno == ENOENT || errno == EACCES)) *does_not_exist = 1; else error_callback (data, filename, errno); -- 2.30.2