From 70cc6b0a022c1bfd8d17d5e931b276cb2ef2a456 Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Thu, 16 Jun 2016 13:41:48 +0200 Subject: [PATCH] i965/vec4: prevent copy-propagation from values with a different type size Because the meaning of the swizzles and writemasks involved is different, so replacing the source would lead to different semantics. Reviewed-by: Matt Turner --- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp b/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp index 55413abbc6e..4ef34f25dfc 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp +++ b/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp @@ -324,6 +324,13 @@ try_copy_propagate(const struct gen_device_info *devinfo, value.file != ATTR) return false; + /* If the type of the copy value is different from the type of the + * instruction then the swizzles and writemasks involved don't have the same + * meaning and simply replacing the source would produce different semantics. + */ + if (type_sz(value.type) != type_sz(inst->src[arg].type)) + return false; + if (devinfo->gen >= 8 && (value.negate || value.abs) && is_logic_op(inst->opcode)) { return false; -- 2.30.2