From 70f0e2883a4554c39445a4fd27e1490fcc828853 Mon Sep 17 00:00:00 2001 From: Jason Merrill Date: Mon, 10 Mar 2003 17:04:09 -0500 Subject: [PATCH] re PR c++/9798 (Infinite recursion (segfault) in cp/decl.c:push_using_directive with recusive using directives) PR c++/9798 * decl.c (push_using_directive): Push before recursing. From-SVN: r64133 --- gcc/cp/ChangeLog | 5 ++++- gcc/cp/decl.c | 9 +++++---- gcc/testsuite/g++.dg/lookup/using3.C | 12 ++++++++++++ 3 files changed, 21 insertions(+), 5 deletions(-) create mode 100644 gcc/testsuite/g++.dg/lookup/using3.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 403747113f4..9f70757d19d 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,6 +1,9 @@ 2003-03-10 Jason Merrill - PR c++/9868 + PR c++/9798 + * decl.c (push_using_directive): Push before recursing. + + PR c++/9868, c++/9524 * call.c (resolve_scoped_fn_name): Handle the case of a function pointer member. diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c index b3e617f88f4..eeae35ad0df 100644 --- a/gcc/cp/decl.c +++ b/gcc/cp/decl.c @@ -4442,14 +4442,15 @@ push_using_directive (tree used) if (purpose_member (used, ud) != NULL_TREE) POP_TIMEVAR_AND_RETURN (TV_NAME_LOOKUP, NULL_TREE); - /* Recursively add all namespaces used. */ - for (iter = DECL_NAMESPACE_USING (used); iter; iter = TREE_CHAIN (iter)) - push_using_directive (TREE_PURPOSE (iter)); - ancestor = namespace_ancestor (current_decl_namespace (), used); ud = current_binding_level->using_directives; ud = tree_cons (used, ancestor, ud); current_binding_level->using_directives = ud; + + /* Recursively add all namespaces used. */ + for (iter = DECL_NAMESPACE_USING (used); iter; iter = TREE_CHAIN (iter)) + push_using_directive (TREE_PURPOSE (iter)); + POP_TIMEVAR_AND_RETURN (TV_NAME_LOOKUP, ud); } diff --git a/gcc/testsuite/g++.dg/lookup/using3.C b/gcc/testsuite/g++.dg/lookup/using3.C new file mode 100644 index 00000000000..f3642759717 --- /dev/null +++ b/gcc/testsuite/g++.dg/lookup/using3.C @@ -0,0 +1,12 @@ +// PR c++/9798 + +namespace std { } +namespace STL { using namespace std; } +namespace std { + using namespace STL; +} +namespace STL { + struct A { + void B() { using namespace std; } + }; +} -- 2.30.2