From 7104e59bece90e387d70f617eb7ed4c34087283d Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 20 Feb 2018 11:41:54 -0500 Subject: [PATCH] remote-sim: Add missing ATTRIBUTE_PRINTF Fixes: /home/emaisin/src/binutils-gdb/gdb/remote-sim.c:385:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral] vfprintf_filtered (gdb_stdout, format, args); ^~~~~~ /home/emaisin/src/binutils-gdb/gdb/remote-sim.c:394:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral] vfprintf_filtered (gdb_stdout, format, ap); ^~~~~~ /home/emaisin/src/binutils-gdb/gdb/remote-sim.c:402:34: error: format string is not a string literal [-Werror,-Wformat-nonliteral] vfprintf_filtered (gdb_stderr, format, ap); ^~~~~~ /home/emaisin/src/binutils-gdb/gdb/remote-sim.c:413:11: error: format string is not a string literal [-Werror,-Wformat-nonliteral] verror (format, args); ^~~~~~ 4 errors generated. gdb/ChangeLog: * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered, gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF. --- gdb/ChangeLog | 5 +++++ gdb/remote-sim.c | 10 +++++----- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index eac15722802..9f78ed33cc3 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-02-20 Simon Marchi + + * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered, + gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF. + 2018-02-20 Markus Metzger * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp. diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c index 2f8fb68634e..456fa8a3fe0 100644 --- a/gdb/remote-sim.c +++ b/gdb/remote-sim.c @@ -376,8 +376,8 @@ gdb_os_flush_stderr (host_callback *p) /* GDB version of printf_filtered callback. */ -static void -gdb_os_printf_filtered (host_callback * p, const char *format,...) +static void ATTRIBUTE_PRINTF (2, 3) +gdb_os_printf_filtered (host_callback * p, const char *format, ...) { va_list args; @@ -388,7 +388,7 @@ gdb_os_printf_filtered (host_callback * p, const char *format,...) /* GDB version of error vprintf_filtered. */ -static void +static void ATTRIBUTE_PRINTF (2, 0) gdb_os_vprintf_filtered (host_callback * p, const char *format, va_list ap) { vfprintf_filtered (gdb_stdout, format, ap); @@ -396,7 +396,7 @@ gdb_os_vprintf_filtered (host_callback * p, const char *format, va_list ap) /* GDB version of error evprintf_filtered. */ -static void +static void ATTRIBUTE_PRINTF (2, 0) gdb_os_evprintf_filtered (host_callback * p, const char *format, va_list ap) { vfprintf_filtered (gdb_stderr, format, ap); @@ -404,7 +404,7 @@ gdb_os_evprintf_filtered (host_callback * p, const char *format, va_list ap) /* GDB version of error callback. */ -static void +static void ATTRIBUTE_PRINTF (2, 3) gdb_os_error (host_callback * p, const char *format, ...) { va_list args; -- 2.30.2