From 717d4ae930a64226d909e97fc672dccfa6a19ca2 Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Mon, 19 Sep 2011 06:17:20 -0700 Subject: [PATCH] Faults: Get rid of the unused isAlignmentFault and isMachineCheckFault. These functions aren't called anywhere and are probably only theoretically useful. --- src/arch/alpha/faults.hh | 1 - src/arch/power/faults.hh | 6 ------ src/arch/sparc/faults.hh | 12 ++---------- src/sim/faults.hh | 2 -- 4 files changed, 2 insertions(+), 19 deletions(-) diff --git a/src/arch/alpha/faults.hh b/src/arch/alpha/faults.hh index 2b45a430c..edac1cda6 100644 --- a/src/arch/alpha/faults.hh +++ b/src/arch/alpha/faults.hh @@ -68,7 +68,6 @@ class MachineCheckFault : public AlphaFault FaultName name() const {return _name;} FaultVect vect() {return _vect;} FaultStat & countStat() {return _count;} - bool isMachineCheckFault() const {return true;} }; class AlignmentFault : public AlphaFault diff --git a/src/arch/power/faults.hh b/src/arch/power/faults.hh index f1977150c..6aedd7e00 100644 --- a/src/arch/power/faults.hh +++ b/src/arch/power/faults.hh @@ -83,12 +83,6 @@ class AlignmentFault : public PowerFault : PowerFault("Alignment") { } - - bool - isAlignmentFault() const - { - return true; - } }; diff --git a/src/arch/sparc/faults.hh b/src/arch/sparc/faults.hh index bee29ee5e..31209440f 100644 --- a/src/arch/sparc/faults.hh +++ b/src/arch/sparc/faults.hh @@ -139,11 +139,7 @@ class CleanWindow : public SparcFault {}; class DivisionByZero : public SparcFault {}; class InternalProcessorError : - public SparcFault -{ - public: - bool isMachineCheckFault() const { return true; } -}; + public SparcFault {}; class InstructionInvalidTSBEntry : public SparcFault {}; @@ -159,11 +155,7 @@ class DataAccessError : public SparcFault {}; class DataAccessProtection : public SparcFault {}; class MemAddressNotAligned : - public SparcFault -{ - public: - bool isAlignmentFault() const { return true; } -}; + public SparcFault {}; class LDDFMemAddressNotAligned : public SparcFault {}; diff --git a/src/sim/faults.hh b/src/sim/faults.hh index f5e9aded1..2d91b8d46 100644 --- a/src/sim/faults.hh +++ b/src/sim/faults.hh @@ -57,8 +57,6 @@ class FaultBase : public RefCounted virtual FaultName name() const = 0; virtual void invoke(ThreadContext * tc, StaticInstPtr inst = StaticInst::nullStaticInstPtr); - virtual bool isMachineCheckFault() const {return false;} - virtual bool isAlignmentFault() const {return false;} }; class UnimpFault : public FaultBase -- 2.30.2