From 717f99b34a329d21d7b65e3193c6bf2162ad7964 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Alejandro=20Pi=C3=B1eiro?= Date: Fri, 15 Apr 2016 19:08:04 +0200 Subject: [PATCH] i965: return PASSTHRU surface types also on gen7 Although gen7 doesn't include surface types as a valid conversion format, we return it, as it reflects what we want to achieve, even if we need to workaround it on gen < 8. Reviewed-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c b/src/mesa/drivers/dri/i965/brw_draw_upload.c index b7527f2cd9b..79eb634fc45 100644 --- a/src/mesa/drivers/dri/i965/brw_draw_upload.c +++ b/src/mesa/drivers/dri/i965/brw_draw_upload.c @@ -231,9 +231,13 @@ double_types(struct brw_context *brw, * 64-bit components are stored in the URB without any conversion." * Also included on BDW PRM, Volume 7, page 470, table "Source Element * Formats Supported in VF Unit" - * Previous PRMs don't include those references. + * + * Previous PRMs don't include those references, so for gen7 we can't use + * PASSTHRU formats directly. But in any case, we prefer to return passthru + * even in that case, because that reflects what we want to achieve, even + * if we would need to workaround on gen < 8. */ - return (brw->gen >= 8 && doubles + return (doubles ? double_types_passthru[size] : double_types_float[size]); } -- 2.30.2