From 72275f1e6a2566569ac23fb8a2b2f6dbcf535408 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Fri, 4 Aug 2023 07:58:32 -0600 Subject: [PATCH] Remove value::copy call from gdbpy_get_varobj_pretty_printer I noticed a call to value::copy in gdbpy_get_varobj_pretty_printer, and I couldn't figure out why it was there. I think maybe it came from the time when value_to_value_object would release values from the value chain -- but that was removed in commit f3d3bbbc. This patch removes this call. Regression tested on x86-64 Fedora 36. --- gdb/python/py-prettyprint.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/gdb/python/py-prettyprint.c b/gdb/python/py-prettyprint.c index 29ae0205ec7..cccc94e319b 100644 --- a/gdb/python/py-prettyprint.c +++ b/gdb/python/py-prettyprint.c @@ -661,15 +661,6 @@ apply_varobj_pretty_printer (PyObject *printer_obj, gdbpy_ref<> gdbpy_get_varobj_pretty_printer (struct value *value) { - try - { - value = value->copy (); - } - catch (const gdb_exception &except) - { - GDB_PY_HANDLE_EXCEPTION (except); - } - gdbpy_ref<> val_obj (value_to_value_object (value)); if (val_obj == NULL) return NULL; -- 2.30.2