From 72b5d09937fa2dac8ca7c801b9ddefe1b0176b6f Mon Sep 17 00:00:00 2001 From: Jan Kratochvil Date: Wed, 20 Jul 2016 16:17:04 +0200 Subject: [PATCH] testsuite patch: Skip py-unwind.exp on x86_64 -m32 (gdb) source /home/jkratoch/redhat/gdb-clean/gdb/testsuite/outputs/gdb.python/py-unwind/py-unwind.py^M Python script imported^M Python Exception Bad register: ^M (gdb) FAIL: gdb.python/py-unwind.exp: import python scripts class TestUnwinder(Unwinder): AMD64_RBP = 6 AMD64_RSP = 7 AMD64_RIP = 16 On Tue, 19 Jul 2016 12:06:09 +0200, Yao Qi wrote: py-unwind.exp does nothing on arch specific thing, so py-unwind.exp shouldn't be aware of the arch difference, but py-unwind.py should. On Tue, 19 Jul 2016 20:04:33 +0200, Pedro Alves wrote: How about we handle this in the .exp file for now and leave something more complicated for when the test is first ported to some other arch. WDYT? gdb/testsuite/ChangeLog 2016-07-20 Jan Kratochvil * gdb.python/py-unwind.exp: Test also ![is_lp64_target]. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.python/py-unwind.exp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index fb1f3b12922..3ef78b7dd1e 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2016-07-20 Jan Kratochvil + + * gdb.python/py-unwind.exp: Test also ![is_lp64_target]. + 2016-07-19 Pedro Alves * gdb.opt/inline-break.exp: Remove optimize=-O2. diff --git a/gdb/testsuite/gdb.python/py-unwind.exp b/gdb/testsuite/gdb.python/py-unwind.exp index 5172a03c75a..e31a4727564 100644 --- a/gdb/testsuite/gdb.python/py-unwind.exp +++ b/gdb/testsuite/gdb.python/py-unwind.exp @@ -28,7 +28,7 @@ if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile}] } { if { [skip_python_tests] } { continue } # This test runs on a specific platform. -if { ! [istarget x86_64-*]} { continue } +if { ![istarget x86_64-*-* ] || ![is_lp64_target] } { continue } # The following tests require execution. -- 2.30.2